Bug 126456

Summary:

Add lineageOfType renderer iterator and start using it.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Layout and Rendering

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, koivisto, kondapallykalyan, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Andreas Kling 2014-01-03 13:29:06 PST

We should have a lineageOfType iterator for renderers, just like we already do for elements.

Comment 1 Andreas Kling 2014-01-03 14:04:59 PST

Created attachment 220337 [details]
Patch

Comment 2 Geoffrey Garen 2014-01-03 14:45:26 PST

Comment on attachment 220337 [details]
Patch

r=me

Comment 3 WebKit Commit Bot 2014-01-03 15:15:52 PST

Comment on attachment 220337 [details]
Patch

Clearing flags on attachment: 220337

Committed r161288: <http://trac.webkit.org/changeset/161288>

Comment 4 WebKit Commit Bot 2014-01-03 15:15:54 PST

All reviewed patches have been landed.  Closing bug.

Comment 5 Simon Fraser (smfr) 2014-01-07 11:34:04 PST

Comment on attachment 220337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220337&action=review

> Source/WebCore/rendering/RenderAncestorIterator.h:187
> +inline RenderAncestorIteratorAdapter<T> lineageOfType(RenderObject& first)

"lineageOfType" doesn't tell me that this is walking the ancestor chain (you can have a descendant lineage as well as an ancestor lineage). Can we rename it to ancestorLineageOfType()?