Bug 126454

Summary: [super dealloc] missing in Source/JavaScriptCore/API/tests/testapi.mm, fails to build with -Werror,-Wobjc-missing-super-calls
Product: WebKit Reporter: David Farler <dfarler>
Component: JavaScriptCoreAssignee: David Farler <dfarler>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ddkilzer, ggaren, mrowe
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

David Farler
Reported 2014-01-03 12:54:01 PST
Source/JavaScriptCore/API/tests/testapi.mm:172:1: error: method possibly missing a [super dealloc] call [-Werror,-Wobjc-missing-super-calls] Source/JavaScriptCore/API/tests/testapi.mm:440:1: error: method possibly missing a [super dealloc] call [-Werror,-Wobjc-missing-super-calls]
Attachments
Patch (1.59 KB, patch)
2014-01-03 12:58 PST, David Farler 		no flags
DetailsFormatted DiffDiff
Patch (1.67 KB, patch)
2014-01-03 17:17 PST, David Farler 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Farler
Comment 1 2014-01-03 12:58:05 PST
Created attachment 220331 [details] Patch
Mark Rowe (bdash)
Comment 2 2014-01-03 13:10:43 PST
Comment on attachment 220331 [details] Patch This'll break the 64-bit build.
Mark Rowe (bdash)
Comment 3 2014-01-03 13:12:01 PST
The file is built with ARC enabled on all architectures that support it (e.g., everything but i386), and [super dealloc] will generate an error under ARC.
Geoffrey Garen
Comment 4 2014-01-03 14:09:57 PST
Comment on attachment 220331 [details] Patch It looks like we've been using "#if !__has_feature(objc_arc)" to handle stuff like this.
David Farler
Comment 5 2014-01-03 14:21:26 PST
Nice, that’s exactly what I was testing locally.
David Farler
Comment 6 2014-01-03 17:17:54 PST
Created attachment 220357 [details] Patch
Geoffrey Garen
Comment 7 2014-01-03 17:25:29 PST
Comment on attachment 220357 [details] Patch r=me
David Farler
Comment 8 2014-01-03 17:45:44 PST
Comment on attachment 220357 [details] Patch Thanks!
WebKit Commit Bot
Comment 9 2014-01-03 18:14:38 PST
Comment on attachment 220357 [details] Patch Clearing flags on attachment: 220357 Committed r161304: <http://trac.webkit.org/changeset/161304>
WebKit Commit Bot
Comment 10 2014-01-03 18:14:40 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.