Bug 126440

Summary: [MediaControls][iOS] Enable JavaScript Media Controls on iOS.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch eric.carlson: review+

Description Jer Noble 2014-01-03 10:39:39 PST 
[MediaControls][iOS] Enable JavaScript Media Controls on iOS.
Comment 1 Jer Noble 2014-01-03 11:19:28 PST 
Created attachment 220321 [details]
Patch
Comment 2 Eric Carlson 2014-01-03 12:06:27 PST 
Comment on attachment 220321 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220321&action=review

> Source/WebCore/DerivedSources.make:850
> +ifeq ($(WTF_PLATFORM_IOS),1)

Nit: there should be a space after the comma.

> Source/WebCore/DerivedSources.make:870
> +ifeq ($(WTF_PLATFORM_IOS),1)

Ditto.

> Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css:185
> +    /* rotateZ() forces the layer into compositing mode.
> +    Slider thumbs are small, so forcing a compositing layer is inexpensive,
> +       and it keeps the slider from having to repaint while sliding. */

Nit: good comment, but strange indentation.
Comment 3 Jer Noble 2014-01-03 12:47:03 PST 
Committed r161280: <http://trac.webkit.org/changeset/161280>
Comment 4 Geoffrey Garen 2014-01-03 14:13:06 PST 
Comment on attachment 220321 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220321&action=review

> Source/WebCore/rendering/RenderThemeIOS.mm:1205
>  String RenderThemeIOS::mediaControlsScript()

Can we refactor this to use JSScriptCreateReferencingImmortalASCIIText, or at least JSScriptCreateFromString?
Comment 5 Jer Noble 2014-01-03 14:38:59 PST 
(In reply to comment #4)
> (From update of attachment 220321 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=220321&action=review
> 
> > Source/WebCore/rendering/RenderThemeIOS.mm:1205
> >  String RenderThemeIOS::mediaControlsScript()
> 
> Can we refactor this to use JSScriptCreateReferencingImmortalASCIIText, or at least JSScriptCreateFromString?

Absolutely.  We could do the same for the Mac version as well.