Summary: | VibrationPattern should allocate an single vector instance for single integer input | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jinwoo Song <jinwoo7.song> | ||||
Component: | WebCore Misc. | Assignee: | Jinwoo Song <jinwoo7.song> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bunhere, cdumez, commit-queue, gyuyoung.kim, gyuyoung.kim, kihong.kwon, rakuco | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Jinwoo Song
2014-01-02 22:32:18 PST
Created attachment 220281 [details]
Patch
CC'ing Kihong Comment on attachment 220281 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220281&action=review LGTM > Source/WebCore/Modules/vibration/NavigatorVibration.cpp:43 > + return NavigatorVibration::vibrate(navigator, VibrationPattern(1, time)); Good catch ! We have missed this one so far. Comment on attachment 220281 [details] Patch Clearing flags on attachment: 220281 Committed r161257: <http://trac.webkit.org/changeset/161257> All reviewed patches have been landed. Closing bug. |