Bug 126417

Summary: VibrationPattern should allocate an single vector instance for single integer input
Product: WebKit Reporter: Jinwoo Song <jinwoo7.song>
Component: WebCore Misc.Assignee: Jinwoo Song <jinwoo7.song>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, commit-queue, gyuyoung.kim, gyuyoung.kim, kihong.kwon, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jinwoo Song
Reported 2014-01-02 22:32:18 PST
When the Vibration pattern is set with a single integer, the VibrationPattern should set the vibration time with this value. But the VibrationPattern(unsigned vector) was initialized with a single parameter, the vibration time, so the time was used to set the size of vector.
Attachments
Patch (6.19 KB, patch)
2014-01-02 22:48 PST, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jinwoo Song
Comment 1 2014-01-02 22:48:43 PST
Created attachment 220281 [details] Patch
Gyuyoung Kim
Comment 2 2014-01-02 23:44:31 PST
CC'ing Kihong
Gyuyoung Kim
Comment 3 2014-01-03 00:04:05 PST
Comment on attachment 220281 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220281&action=review LGTM > Source/WebCore/Modules/vibration/NavigatorVibration.cpp:43 > + return NavigatorVibration::vibrate(navigator, VibrationPattern(1, time)); Good catch ! We have missed this one so far.
WebKit Commit Bot
Comment 4 2014-01-03 00:41:19 PST
Comment on attachment 220281 [details] Patch Clearing flags on attachment: 220281 Committed r161257: <http://trac.webkit.org/changeset/161257>
WebKit Commit Bot
Comment 5 2014-01-03 00:41:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.