Bug 126408

Summary:

[WebGL2] Context creation

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

WebGL

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, clopez, commit-queue, dino, eric.carlson, ossy, rniwa, roger_fong, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

140424, 140431

Bug Blocks:

126404

Attachments:

Description	Flags
patch	none
patch	none
Patch	dino: review+
patch v2	none
Archive of layout-test-results from ews103 for mac-mavericks	none
patch v3	dino: review+, buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-mavericks	none

Dean Jackson

Reported 2014-01-02 14:49:53 PST

Support creation of a WebGL2 context var ctx = canvas.getContext("webgl2")

Attachments
patch (1.52 MB, patch) 2015-01-12 16:52 PST, Roger Fong	no flags	Details Formatted Diff Diff
patch (1.50 MB, patch) 2015-01-13 13:01 PST, Roger Fong	no flags	Details Formatted Diff Diff
Patch (1.50 MB, patch) 2015-01-13 13:44 PST, Roger Fong	dino: review+	Details Formatted Diff Diff
patch v2 (875.85 KB, patch) 2015-01-16 15:06 PST, Roger Fong	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-mavericks (610.72 KB, application/zip) 2015-01-16 15:41 PST, Build Bot	no flags	Details
patch v3 (838.72 KB, patch) 2015-01-16 16:41 PST, Roger Fong	dino: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-mavericks (549.12 KB, application/zip) 2015-01-16 17:46 PST, Build Bot	no flags	Details
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Dean Jackson

Comment 1 2014-01-02 14:50:49 PST

<rdar://problem/15002170>

Radar WebKit Bug Importer

Comment 2 2014-01-02 14:51:15 PST

<rdar://problem/15740768>

Roger Fong

Comment 3 2015-01-12 16:52:42 PST

Created attachment 244478 [details] patch

Roger Fong

Comment 4 2015-01-12 16:53:49 PST

I've neglected to fix the non mac ports. Will do in next patch.

Roger Fong

Comment 5 2015-01-13 13:01:11 PST

Created attachment 244537 [details] patch Will fix Windows build after the patch lands. Ignore remaining style errors, I've made all the style fixes I thin are appropriate for this changeset.

Roger Fong

Comment 6 2015-01-13 13:44:55 PST

Created attachment 244538 [details] Patch

Dean Jackson

Comment 7 2015-01-13 14:37:36 PST

Comment on attachment 244538 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244538&action=review rs=me with a small comment > Source/WebCore/html/canvas/CanvasRenderingContext.h:57 > virtual bool is2d() const { return false; } > virtual bool is3d() const { return false; } > virtual bool isAccelerated() const { return false; } > + virtual String type() const { return m_type; } I wonder if we should change this to be: is2d(), isWebGL(), isWebGL2() and not have a type flag. We only support two (now three) context types, so we can think about a type field if we ever have more (which isn't really likely in the near term).

Chris Dumez

Comment 8 2015-01-13 16:37:23 PST

This may have broken the iOS build: Source/WebCore/html/canvas/WebGLContextGroup.h:29:10: error: 'WebGLRenderingContextBase.h' file not found with <angled> include; use "quotes" instead #include <WebGLRenderingContextBase.h> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ "WebGLRenderingContextBase.h" 1 error generated.

Chris Dumez

Comment 9 2015-01-13 16:39:25 PST

and /Volumes/Data/cdumez/WebKit/OpenSource/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:118:5: error: use of undeclared identifier 'm_type' m_type = "2d"; ^ 1 error generated.

Chris Dumez

Comment 10 2015-01-13 16:45:37 PST

Follow-up build fix landed in <https://trac.webkit.org/r178392>.

Carlos Alberto Lopez Perez

Comment 11 2015-01-13 17:49:13 PST

(In reply to comment #4) > I've neglected to fix the non mac ports. Will do in next patch. The GTK build fails with this: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Build%29/builds/54425/steps/compile-webkit/logs/stdio Maybe you mean 'NULL' instead of 'nil' ? (C++)

Roger Fong

Comment 12 2015-01-13 18:12:01 PST

I think all the builds are fixed now: Main patch was landed: http://trac.webkit.org/changeset/178390 Windows and GTK fix was landed: http://trac.webkit.org/changeset/178398

Roger Fong

Comment 13 2015-01-13 19:12:10 PST

Keeping track of test failures: https://bugs.webkit.org/show_bug.cgi?id=140423

Csaba Osztrogonác

Comment 14 2015-01-13 23:20:28 PST

(In reply to comment #12) > I think all the builds are fixed now: > > Main patch was landed: > http://trac.webkit.org/changeset/178390 > > Windows and GTK fix was landed: > http://trac.webkit.org/changeset/178398 It broke the EFL/GTK build: bug140424

Alexey Proskuryakov

Comment 15 2015-01-14 00:06:01 PST

As mentioned in bug 140423 comment 1, changes to js/dom/global-constructors-attributes.html results look quite suspicious. Given that you also had to skip all WebGL tests, this seems like too many issues to keep in the tree, Ill try to roll out if I can.

WebKit Commit Bot

Comment 16 2015-01-14 00:06:20 PST

Re-opened since this is blocked by bug 140431

Roger Fong

Comment 17 2015-01-16 15:06:27 PST

Created attachment 244806 [details] patch v2 WebGL1RenderingContext is renamed to WebGLRenderingContext

WebKit Commit Bot

Comment 18 2015-01-16 15:08:36 PST

Attachment 244806 [details] did not pass style-queue: ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:131: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:133: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:224: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:227: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:229: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:231: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:234: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:241: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:242: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:244: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:246: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:248: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:251: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:254: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:255: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:256: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:256: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:257: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:258: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:259: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:259: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:260: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:261: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:262: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:262: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:263: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:264: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:265: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:265: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:266: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:267: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:268: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:268: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:269: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:270: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:271: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:271: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:272: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:273: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:274: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:274: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:275: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:276: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:277: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:277: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:278: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:279: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:279: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:280: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:281: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:281: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:282: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:283: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:283: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:290: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:293: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:296: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:299: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:301: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:485: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:621: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:648: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:653: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:654: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:655: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:656: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:657: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:668: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:669: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:670: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:671: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:682: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:683: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:695: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:67: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:147: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:501: Missing space after , [whitespace/comma] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:731: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:732: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:733: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:774: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:776: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1370: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1401: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1413: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1439: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1486: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1489: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1559: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3862: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3870: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3954: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3955: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3964: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3965: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3966: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3967: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3968: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/ca nvas/WebGLRenderingContextBase.cpp:3978: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3984: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4025: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4042: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4086: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4218: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4219: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4228: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4229: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4230: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4231: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4232: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4247: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4273: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4290: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4306: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5050: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5055: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5057: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5059: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5061: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5063: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5065: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5317: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5318: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5319: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5320: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5321: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5378: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5454: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5455: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5560: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:6218: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:6232: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/DerivedSources.cpp:72: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/bindings/js/JSWebGLRenderingContextBaseCustom.cpp:162: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/JSWebGLRenderingContextBaseCustom.cpp:205: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/JSWebGLRenderingContextBaseCustom.cpp:462: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/JSWebGLRenderingContextBaseCustom.cpp:463: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/JSWebGLRenderingContextBaseCustom.cpp:467: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 138 in 95 files If any of these errors are false positives, please file a bug against check-webkit-style.

Roger Fong

Comment 19 2015-01-16 15:11:25 PST

> If any of these errors are false positives, please file a bug against > check-webkit-style. I chose to leave a lot of these style errors here because the spacing and inclusion of parameter names in the header files are there to make things clearer, which is very helpful for WebGL code as many function calls take a slew of various parameters.

Build Bot

Comment 20 2015-01-16 15:41:09 PST

Comment on attachment 244806 [details] patch v2 Attachment 244806 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5328759708188672 New failing tests: js/dom/global-constructors-attributes.html

Build Bot

Comment 21 2015-01-16 15:41:12 PST

Created attachment 244811 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5

Roger Fong

Comment 22 2015-01-16 16:41:02 PST

Created attachment 244819 [details] patch v3 With a layout test fix. Actual build (not test) results will not differ from patch v2.

WebKit Commit Bot

Comment 23 2015-01-16 16:56:10 PST

Attachment 244819 [details] did not pass style-queue: ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:131: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:133: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:224: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:227: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:229: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:231: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:234: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:241: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:242: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:244: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:246: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:248: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:251: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:254: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:255: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:256: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:256: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:257: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:258: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:259: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:259: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:260: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:261: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:262: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:262: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:263: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:264: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:265: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:265: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:266: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:267: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:268: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:268: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:269: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:270: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:271: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:271: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:272: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:273: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:274: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:274: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:275: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:276: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:277: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:277: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:278: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:279: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:279: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:280: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:281: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:281: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:282: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:283: The parameter name "location" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:283: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:290: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:293: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:296: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:299: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:301: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:485: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:648: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:653: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:654: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:655: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:656: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:657: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:668: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:669: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:670: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:671: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:682: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:683: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.h:695: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:147: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:731: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:732: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:733: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:774: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:776: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1370: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1401: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1413: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1439: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1486: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1489: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1559: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3862: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3870: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3954: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3955: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3964: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3965: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3966: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3967: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3968: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3977: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3983: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4024: Weird number of spaces at l ine-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4041: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4085: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4217: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4218: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4227: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4228: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4229: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4230: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4231: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4245: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4271: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4288: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4304: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5048: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5053: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5055: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5057: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5059: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5061: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5063: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5315: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5316: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5317: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5318: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5319: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5376: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5452: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5453: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5558: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:6216: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:6230: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/bindings/js/JSWebGLRenderingContextBaseCustom.cpp:162: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/JSWebGLRenderingContextBaseCustom.cpp:205: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/JSWebGLRenderingContextBaseCustom.cpp:462: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/JSWebGLRenderingContextBaseCustom.cpp:463: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/bindings/js/JSWebGLRenderingContextBaseCustom.cpp:467: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 134 in 96 files If any of these errors are false positives, please file a bug against check-webkit-style.

Dean Jackson

Comment 24 2015-01-16 17:11:43 PST

Comment on attachment 244819 [details] patch v3 I talked with Roger about this. He'll split into two commits - one that renames the WebGLRenderingContext to WebGLRenderingContextBase (although keeping the contents the same), and then a followup to change the name in the contents. That should be smaller.

Build Bot

Comment 25 2015-01-16 17:46:50 PST

Comment on attachment 244819 [details] patch v3 Attachment 244819 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5989221659574272 New failing tests: js/dom/global-constructors-attributes.html

Build Bot

Comment 26 2015-01-16 17:46:54 PST

Created attachment 244824 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5

Roger Fong

Comment 27 2015-01-19 15:29:58 PST

ReCommitted: https://trac.webkit.org/changeset/178674 With a minor test fix here: https://trac.webkit.org/changeset/178677

Csaba Osztrogonác

Comment 28 2015-09-14 10:51:39 PDT

Comment on attachment 244806 [details] patch v2 Cleared review? from attachment 244806 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).

Note You need to log in before you can comment on or make changes to this bug.