Bug 126400

Summary: "+" is very confusing at http://build.webkit.org/dashboard
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: bshafiei, commit-queue, mitz, rniwa, thorton, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
none
proposed patch
none
proposed patch none

Alexey Proskuryakov
Reported 2014-01-02 14:04:41 PST
Getting lots of negative feedback about this one.
Attachments
proposed patch (3.30 KB, patch)
2014-01-02 14:20 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
proposed patch (4.55 KB, text/plain)
2014-01-02 14:35 PST, Alexey Proskuryakov 		no flags
Details
proposed patch (3.32 KB, patch)
2014-01-02 14:37 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2014-01-02 14:20:45 PST
Created attachment 220250 [details] proposed patch
WebKit Commit Bot
Comment 2 2014-01-02 14:21:42 PST
Attachment 220250 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js', u'Tools/ChangeLog', '--commit-queue']" exit_code: 1 ERROR: Tools/ChangeLog:3: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexey Proskuryakov
Comment 3 2014-01-02 14:35:09 PST
Created attachment 220253 [details] proposed patch Indeed.
Alexey Proskuryakov
Comment 4 2014-01-02 14:37:03 PST
Created attachment 220254 [details] proposed patch Oops. Third time a charm?
Alexey Proskuryakov
Comment 5 2014-01-02 14:50:39 PST
Comment on attachment 220254 [details] proposed patch Let's see how well this works for everyone.
WebKit Commit Bot
Comment 6 2014-01-02 15:20:48 PST
Comment on attachment 220254 [details] proposed patch Clearing flags on attachment: 220254 Committed r161233: <http://trac.webkit.org/changeset/161233>
WebKit Commit Bot
Comment 7 2014-01-02 15:20:50 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.