Bug 126400

Summary:

"+" is very confusing at http://build.webkit.org/dashboard

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bshafiei, commit-queue, mitz, rniwa, thorton, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch	none
proposed patch	none
proposed patch	none

Description Alexey Proskuryakov 2014-01-02 14:04:41 PST

Getting lots of negative feedback about this one.

Comment 1 Alexey Proskuryakov 2014-01-02 14:20:45 PST

Created attachment 220250 [details]
proposed patch

Comment 2 WebKit Commit Bot 2014-01-02 14:21:42 PST

Attachment 220250 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js', u'Tools/ChangeLog', '--commit-queue']" exit_code: 1
ERROR: Tools/ChangeLog:3:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Alexey Proskuryakov 2014-01-02 14:35:09 PST

Created attachment 220253 [details]
proposed patch

Indeed.

Comment 4 Alexey Proskuryakov 2014-01-02 14:37:03 PST

Created attachment 220254 [details]
proposed patch

Oops. Third time a charm?

Comment 5 Alexey Proskuryakov 2014-01-02 14:50:39 PST

Comment on attachment 220254 [details]
proposed patch

Let's see how well this works for everyone.

Comment 6 WebKit Commit Bot 2014-01-02 15:20:48 PST

Comment on attachment 220254 [details]
proposed patch

Clearing flags on attachment: 220254

Committed r161233: <http://trac.webkit.org/changeset/161233>

Comment 7 WebKit Commit Bot 2014-01-02 15:20:50 PST

All reviewed patches have been landed.  Closing bug.