Bug 126400 - "+" is very confusing at http://build.webkit.org/dashboard
Summary: "+" is very confusing at http://build.webkit.org/dashboard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-02 14:04 PST by Alexey Proskuryakov
Modified: 2014-01-02 15:20 PST (History)
6 users (show)

See Also:

Attachments
proposed patch (3.30 KB, patch)
2014-01-02 14:20 PST, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
proposed patch (4.55 KB, text/plain)
2014-01-02 14:35 PST, Alexey Proskuryakov 		no flags Details
proposed patch (3.32 KB, patch)
2014-01-02 14:37 PST, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-01-02 14:04:41 PST 
Getting lots of negative feedback about this one.
Comment 1 Alexey Proskuryakov 2014-01-02 14:20:45 PST 
Created attachment 220250 [details]
proposed patch
Comment 2 WebKit Commit Bot 2014-01-02 14:21:42 PST 
Attachment 220250 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js', u'Tools/ChangeLog', '--commit-queue']" exit_code: 1
ERROR: Tools/ChangeLog:3:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alexey Proskuryakov 2014-01-02 14:35:09 PST 
Created attachment 220253 [details]
proposed patch

Indeed.
Comment 4 Alexey Proskuryakov 2014-01-02 14:37:03 PST 
Created attachment 220254 [details]
proposed patch

Oops. Third time a charm?
Comment 5 Alexey Proskuryakov 2014-01-02 14:50:39 PST 
Comment on attachment 220254 [details]
proposed patch

Let's see how well this works for everyone.
Comment 6 WebKit Commit Bot 2014-01-02 15:20:48 PST 
Comment on attachment 220254 [details]
proposed patch

Clearing flags on attachment: 220254

Committed r161233: <http://trac.webkit.org/changeset/161233>
Comment 7 WebKit Commit Bot 2014-01-02 15:20:50 PST 
All reviewed patches have been landed.  Closing bug.