Bug 126397 – [GTK] Switch from WTF::Function to std::function in WebProcessTest

• Component: New Bugs
• Status: RESOLVED FIXED

[Zan Dobersek]

[GTK] Switch from WTF::Function to std::function in WebProcessTest

[Zan Dobersek]

Created attachment 220244 [details]
Patch

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Anders Carlsson]

Comment on attachment 220244 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220244&action=review

> Source/WebKit2/ChangeLog:9
> +        following the effor of using STL concepts where possible.

Effort.

(This is great btw, I'd really like to get rid of WTF::Function). 

We usually put a space between the return type and the left parenthesis for function types.

> Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.h:37
> +    WebProcessTest::add(String::fromUTF8(TestName), std::bind(&ClassName::create))

Do you even need std::bind here?

[Zan Dobersek]

Comment on attachment 220244 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220244&action=review

>> Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.h:37
>> +    WebProcessTest::add(String::fromUTF8(TestName), std::bind(&ClassName::create))
> 
> Do you even need std::bind here?

No, std::bind isn't needed.

[Zan Dobersek]

Committed r161253: <http://trac.webkit.org/changeset/161253>