Summary: | [GTK] Switch from WTF::Function to std::function in WebProcessTest | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||
Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cgarcia, commit-queue, gustavo, mrobinson | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Zan Dobersek
2014-01-02 12:48:45 PST
Created attachment 220244 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 220244 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220244&action=review > Source/WebKit2/ChangeLog:9 > + following the effor of using STL concepts where possible. Effort. (This is great btw, I'd really like to get rid of WTF::Function). We usually put a space between the return type and the left parenthesis for function types. > Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.h:37 > + WebProcessTest::add(String::fromUTF8(TestName), std::bind(&ClassName::create)) Do you even need std::bind here? Comment on attachment 220244 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220244&action=review >> Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.h:37 >> + WebProcessTest::add(String::fromUTF8(TestName), std::bind(&ClassName::create)) > > Do you even need std::bind here? No, std::bind isn't needed. Committed r161253: <http://trac.webkit.org/changeset/161253> |