Bug 126385

Summary: Crash when trying to register a custom scheme before network process has been launched
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, beidson, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Carlos Garcia Campos
Reported 2014-01-02 08:42:38 PST
WebContext::registerSchemeForCustomProtocol() uses sendToNetworkingProcess() to send the message to the appropriate networking process. In the case of using web process, sendToNetworkingProcess() first checks if there's already a web process, doing nothing otherwise, but when using the network process it assumes there's already a network process. In both cases it's safe to do nothing, because the schemes will be passed as creation parameters to the process when launched.
Attachments
Patch (2.15 KB, patch)
2014-01-02 08:43 PST, Carlos Garcia Campos 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2014-01-02 08:43:54 PST
Created attachment 220227 [details] Patch
Carlos Garcia Campos
Comment 2 2014-01-07 02:02:30 PST
Committed r161416: <http://trac.webkit.org/changeset/161416>
Note You need to log in before you can comment on or make changes to this bug.