Bug 126368

Summary:

Remove public attachRenderTree

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

DOM

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eflews.bot, esprehn+autocc, gyuyoung.kim, japhet, kangil.han

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	kling: review+, eflews.bot: commit-queue-
another	none

Description Antti Koivisto 2014-01-01 17:51:38 PST

Remove the remaining explicit render tree construction.

Comment 1 Antti Koivisto 2014-01-01 17:57:27 PST

Created attachment 220198 [details]
patch

Comment 2 Andreas Kling 2014-01-01 18:03:25 PST

Comment on attachment 220198 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220198&action=review

r=me

> Source/WebCore/html/shadow/InsertionPoint.h:100
> +inline InsertionPoint& toInsertionPoint(Node& node)
> +{
> +    ASSERT_WITH_SECURITY_IMPLICATION(node.isInsertionPoint());
> +    return static_cast<InsertionPoint&>(node);
> +}
> +
> +inline const InsertionPoint& toInsertionPoint(const Node& node)
> +{
> +    ASSERT_WITH_SECURITY_IMPLICATION(node.isInsertionPoint());
> +    return static_cast<const InsertionPoint&>(node);
> +}

Could we replace this gunk with NODE_TYPE_CASTS(InsertionPoint) instead?

Comment 3 EFL EWS Bot 2014-01-01 19:45:29 PST

Comment on attachment 220198 [details]
patch

Attachment 220198 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/5956219843903488

Comment 4 Antti Koivisto 2014-01-01 23:52:53 PST

Created attachment 220207 [details]
another

Comment 5 Antti Koivisto 2014-01-02 01:46:43 PST

https://trac.webkit.org/r161205 (with fixes)