Bug 126366

Summary: Remove reattachRenderTree
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ahmad.saleem792, ap, bfulgham, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch kling: review+

Description Antti Koivisto 2014-01-01 15:12:40 PST 
Remove the last remaining client.
Comment 1 Antti Koivisto 2014-01-01 15:18:10 PST 
Created attachment 220196 [details]
patch
Comment 2 Andreas Kling 2014-01-01 15:22:50 PST 
Comment on attachment 220196 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220196&action=review

r=me

> Source/WebCore/html/HTMLSelectElement.cpp:1264
> +            RenderMenuList* menuList = toRenderMenuList(renderer());

I'd make this a RenderMenuList&
Comment 3 Darin Adler 2014-01-01 21:36:51 PST 
Comment on attachment 220196 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220196&action=review

> Source/WebCore/html/HTMLSelectElement.cpp:1144
> +    ASSERT(renderer() && renderer()->isMenuList());

Any time we write an ASSERT that would have a "&&" we normally break it into two assertions. That way we can trivially tell which clause is failing if the assertion is hit.
Comment 4 Ahmad Saleem 2022-07-30 06:33:23 PDT 
I think this got landed in this commit:

https://github.com/WebKit/WebKit/commit/86fe1d37c2f5fde8ee8467e98d2d9e76251194c6

Can this be marked as "RESOLVED FIXED"? Thanks!
Comment 5 Ryosuke Niwa 2022-07-30 13:27:46 PDT 
Indeed, this patch got landed.