Bug 126361

Summary:

[CMake] The forwarding headers generated by WebKitMacros.m4 are incompatible with the headers generated by generate-forwarding-headers.pl

Product:

WebKit

Reporter:

Martin Robinson <mrobinson>

Component:

Tools / Tests

Assignee:

Martin Robinson <mrobinson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, gustavo, gyuyoung.kim, pnormand, rakuco

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Martin Robinson 2014-01-01 12:28:46 PST

The headers generated by the CMake macros in WebKitMacros.m4 use absolute paths, while generate-forwarding-headers.pl uses paths relative to the Source directory. This means that when the two paths generate headers into the same directory they will be overwritten unnecessarily if the CMake files change.

Comment 1 Martin Robinson 2014-01-01 12:31:24 PST

Created attachment 220189 [details]
Patch

Comment 2 Philippe Normand 2014-01-03 00:21:22 PST

Is the EWS green? I don't see the bubbles currently.

Comment 3 Philippe Normand 2014-01-03 00:23:23 PST

Comment on attachment 220189 [details]
Patch

Ok yes it's green indeed :) the patch looks good as well!

Comment 4 Martin Robinson 2014-01-03 08:59:21 PST

Comment on attachment 220189 [details]
Patch

Clearing flags on attachment: 220189

Committed r161263: <http://trac.webkit.org/changeset/161263>

Comment 5 Martin Robinson 2014-01-03 08:59:24 PST

All reviewed patches have been landed.  Closing bug.