Bug 126360

Summary:

Updating the scrolling tree should use references to state nodes

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, cmarcelo, commit-queue, jamesr, luiz, sam, simon.fraser, thorton, tonikitoo

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	andersca: review+

Description Simon Fraser (smfr) 2014-01-01 11:08:39 PST

Updating the scrolling tree should use references to state nodes

Comment 1 Simon Fraser (smfr) 2014-01-01 11:10:22 PST

Created attachment 220187 [details]
Patch

Comment 2 Anders Carlsson 2014-01-01 11:43:45 PST

Comment on attachment 220187 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220187&action=review

> Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:76
> +    const ScrollingStateScrollingNode& scrollingStateNode = toScrollingStateScrollingNode(stateNode);

const auto& ?

> Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:121
> +    const ScrollingStateScrollingNode& scrollingStateNode = toScrollingStateScrollingNode(stateNode);

const auto&?

Comment 3 Simon Fraser (smfr) 2014-01-01 11:49:45 PST

https://trac.webkit.org/r161194