Bug 126360 - Updating the scrolling tree should use references to state nodes
Summary: Updating the scrolling tree should use references to state nodes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-01 11:08 PST by Simon Fraser (smfr)
Modified: 2014-01-01 11:49 PST (History)
9 users (show)

See Also:

Attachments
Patch (23.20 KB, patch)
2014-01-01 11:10 PST, Simon Fraser (smfr) 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-01-01 11:08:39 PST 
Updating the scrolling tree should use references to state nodes
Comment 1 Simon Fraser (smfr) 2014-01-01 11:10:22 PST 
Created attachment 220187 [details]
Patch
Comment 2 Anders Carlsson 2014-01-01 11:43:45 PST 
Comment on attachment 220187 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220187&action=review

> Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:76
> +    const ScrollingStateScrollingNode& scrollingStateNode = toScrollingStateScrollingNode(stateNode);

const auto& ?

> Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:121
> +    const ScrollingStateScrollingNode& scrollingStateNode = toScrollingStateScrollingNode(stateNode);

const auto&?
Comment 3 Simon Fraser (smfr) 2014-01-01 11:49:45 PST 
https://trac.webkit.org/r161194