Bug 126359

Summary: Do less synchronous render tree construction
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, kling, rniwa, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
andersca: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion none

Antti Koivisto
Reported 2014-01-01 10:00:10 PST
Remove attachRenderTree calls from a bunch of places.
Attachments
patch (11.47 KB, patch)
2014-01-01 11:16 PST, Antti Koivisto 		andersca: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (504.67 KB, application/zip)
2014-01-01 12:54 PST, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2014-01-01 11:16:15 PST
Created attachment 220188 [details] patch
Anders Carlsson
Comment 2 2014-01-01 11:41:44 PST
Comment on attachment 220188 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=220188&action=review > Source/WebCore/html/HTMLInputElement.cpp:742 > + // This renderer and its children have quite different layouts and styles depending on > + // whether the speech button is visible or not. So we reset the whole thing and recreate > + // to get the right styles and layout. Is this comment still accurate? Maybe tweak it to say something along the lines of "when style recalc happens the render tree will be completely reconstructed"? > Source/WebCore/html/HTMLObjectElement.cpp:-389 > - // FIXME: Style gets recalculated which is suboptimal. Is this FIXME no longer relevant?
Build Bot
Comment 3 2014-01-01 12:54:35 PST
Comment on attachment 220188 [details] patch Attachment 220188 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5402065983504384 New failing tests: fast/overflow/overflow-height-float-not-removed-crash3.html fast/html/object-image-nested-fallback.html
Build Bot
Comment 4 2014-01-01 12:54:36 PST
Created attachment 220191 [details] Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Antti Koivisto
Comment 5 2014-01-01 13:17:51 PST
https://trac.webkit.org/r161195
Note You need to log in before you can comment on or make changes to this bug.