Summary: | [Gtk] WebKitWebInspector has build warnings due to uninitialized didChangeAttachedWidth member | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brendan Long <self> | ||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | b.long, cgarcia, commit-queue, gustavo, mrobinson | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Brendan Long
2013-12-31 15:03:07 PST
Created attachment 220172 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API This is part of my personal quest to destroy all build warnings. With changes like this, should I be landing them myself now? Build output: CXX Source/JavaScriptCore/disassembler/libjavascriptcoregtk_3_0_la-ARM64Disassembler.lo In file included from ../../Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.cpp:27:0: ../../Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.h: In member function 'void JSC::ARM64Disassembler::A64DOpcode::appendUnsignedImmediate64(uint64_t)': ../../Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.h:175:42: error: format '%llx' expects argument of type 'long long unsigned int', but argument 3 has type 'uint64_t {aka long unsigned int}' [-Werror=format=] bufferPrintf("#0x%llx", immediate); ^ ../../Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.h: In member function 'void JSC::ARM64Disassembler::A64DOpcode::appendPCRelativeOffset(uint32_t*, int32_t)': ../../Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.h:180:74: error: format '%llx' expects argument of type 'long long unsigned int', but argument 3 has type 'uint64_t {aka long unsigned int}' [-Werror=format=] bufferPrintf("0x%llx", reinterpret_cast<uint64_t>(pc + immediate)); Er wrong build output. This is what it fixes: ../../Source/WebKit2/UIProcess/API/gtk/WebKitWebInspector.cpp: In function 'WebKitWebInspector* webkitWebInspectorCreate(WebKit::WebInspectorProxy*)': ../../Source/WebKit2/UIProcess/API/gtk/WebKitWebInspector.cpp:331:5: error: missing initializer for member 'WKInspectorClientGtkV0::didChangeAttachedWidth' [-Werror=missing-field-initializers] }; Comment on attachment 220172 [details] Patch Clearing flags on attachment: 220172 Committed r161186: <http://trac.webkit.org/changeset/161186> All reviewed patches have been landed. Closing bug. |