Bug 126350

Summary: [GTK] [CMake] Fix the WEBKIT_SRC_DIR define when building the WebKit2 GObject API unit tests
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cgarcia, commit-queue, gustavo, gyuyoung.kim, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch cgarcia: review+

Martin Robinson
Reported 2013-12-31 13:48:35 PST
The define is wrong, so the tests are failing.
Attachments
Patch (1.50 KB, patch)
2013-12-31 13:50 PST, Martin Robinson 		cgarcia: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2013-12-31 13:50:05 PST
Created attachment 220170 [details] Patch
WebKit Commit Bot
Comment 2 2013-12-31 13:50:56 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Carlos Garcia Campos
Comment 3 2014-01-01 02:55:35 PST
Comment on attachment 220170 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220170&action=review > Source/WebKit2/ChangeLog:3 > + [GTK] [CMake] Fix the WEBKIT_SRC_DIR define when building the WebKi2 GObject API unit tests btw, please fix the typo in the changelog before landing
Martin Robinson
Comment 4 2014-01-01 07:38:07 PST
Committed r161189: <http://trac.webkit.org/changeset/161189>
Note You need to log in before you can comment on or make changes to this bug.