Bug 126348

Summary:

ScrollingStateNodes should have a reference to the ScrollingStateTree

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, bdakin, cmarcelo, commit-queue, jamesr, luiz, sam, simon.fraser, thorton, tonikitoo

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	sam: review+

Description Simon Fraser (smfr) 2013-12-31 12:23:17 PST

ScrollingStateNodes should have a reference to the ScrollingStateTree

Comment 1 Simon Fraser (smfr) 2013-12-31 12:25:24 PST

Created attachment 220167 [details]
Patch

Comment 2 Sam Weinig 2013-12-31 22:05:14 PST

Comment on attachment 220167 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220167&action=review

> Source/WebCore/ChangeLog:13
> +        In subclasses access the ScrollingStateTree through a member function.s

Tyop.s

> Source/WebCore/page/scrolling/ScrollingStateTree.cpp:147
> +void ScrollingStateTree::addNode(ScrollingStateNode* node)

Could this take a reference?

Comment 3 Simon Fraser (smfr) 2014-01-01 10:23:02 PST

http://trac.webkit.org/changeset/161191