Bug 126335

Summary: CStack: the GC should not be assuming any limit on the stack size.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, ggaren, mhahnenberg, msaboff, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 126320    
Attachments:
Description Flags
the patch. ggaren: review-

Mark Lam
Reported 2013-12-30 23:30:34 PST
Patch coming.
Attachments
the patch. (1.13 KB, patch)
2013-12-30 23:33 PST, Mark Lam 		ggaren: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2013-12-30 23:33:27 PST
Created attachment 220152 [details] the patch.
Mark Lam
Comment 2 2013-12-30 23:36:10 PST
Landed in r161175 on the jsCStack branch: <http://trac.webkit.org/r161175>.
Geoffrey Garen
Comment 3 2014-01-02 14:05:32 PST
Comment on attachment 220152 [details] the patch. This ChangeLog doesn't explain why you did what you did, so it doesn't meet the minimum bar for a WebKit patch.
Mark Lam
Comment 4 2014-01-09 12:34:35 PST
Will add a comment to the ChangeLog to indicate that we removed this assertion because we don't know the proper size of the stack that the span came from, and hence, we are not able to do a meaningful assertion for it here.
Mark Lam
Comment 5 2014-01-13 17:16:29 PST
(In reply to comment #4) > Will add a comment to the ChangeLog to indicate that we removed this assertion because we don't know the proper size of the stack that the span came from, and hence, we are not able to do a meaningful assertion for it here. The following comment was added as part of r161575: <http://trac.webkit.org/r161575> "We cannot do a meaningful assertion here on the size of the stack span because we don't know the stack bounds that the span came from. Hence, the assertion is now removed."
Mark Lam
Comment 6 2014-01-13 17:59:38 PST
Per our offline discussion, the added comment was satisfactory. ChangeLog review status updated in r161934 on the jsCStack branch: <http://trac.webkit.org/r161934>.
Note You need to log in before you can comment on or make changes to this bug.