| Summary: | CStack: the GC should not be assuming any limit on the stack size. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | fpizlo, ggaren, mhahnenberg, msaboff, oliver | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 126320 | ||||||
| Attachments: |
|
||||||
|
Description
Mark Lam
2013-12-30 23:30:34 PST
Created attachment 220152 [details]
the patch.
Landed in r161175 on the jsCStack branch: <http://trac.webkit.org/r161175>. Comment on attachment 220152 [details]
the patch.
This ChangeLog doesn't explain why you did what you did, so it doesn't meet the minimum bar for a WebKit patch.
Will add a comment to the ChangeLog to indicate that we removed this assertion because we don't know the proper size of the stack that the span came from, and hence, we are not able to do a meaningful assertion for it here. (In reply to comment #4) > Will add a comment to the ChangeLog to indicate that we removed this assertion because we don't know the proper size of the stack that the span came from, and hence, we are not able to do a meaningful assertion for it here. The following comment was added as part of r161575: <http://trac.webkit.org/r161575> "We cannot do a meaningful assertion here on the size of the stack span because we don't know the stack bounds that the span came from. Hence, the assertion is now removed." Per our offline discussion, the added comment was satisfactory. ChangeLog review status updated in r161934 on the jsCStack branch: <http://trac.webkit.org/r161934>. |