Bug 126328

Summary: CStack: Fix JSStack::ensureCapacity() to match LLINT and JIT stack checks
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, ggaren, mhahnenberg, msaboff, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 126320    
Attachments:
Description Flags
the patch. ggaren: review+

Mark Lam
Reported 2013-12-30 21:32:04 PST
JSStack::ensureCapacity() is doing its stack check in a complicated way that can result in it yielding different results than the LLINT and JIT stack checks. So, we'll simplify this code to do the same single pointer comparison against VM::m_jsStackLimit just like the LLINT and JIT does. This is a step towards https://bugs.webkit.org/show_bug.cgi?id=126320.
Attachments
the patch. (2.60 KB, patch)
2013-12-30 21:36 PST, Mark Lam 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2013-12-30 21:36:07 PST
Created attachment 220147 [details] the patch.
Mark Lam
Comment 2 2013-12-30 21:38:47 PST
Landed in r161170 on the jsCStack branch: <http://trac.webkit.org/r161170>.
Geoffrey Garen
Comment 3 2014-01-02 13:16:28 PST
Comment on attachment 220147 [details] the patch. r=me
Mark Lam
Comment 4 2014-01-02 15:21:30 PST
Thanks for the review. Status updated in r161232: <http://trac.webkit.org/r161232>.
Note You need to log in before you can comment on or make changes to this bug.