| Summary: | Use getc rather than getbyte on older ruby | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jeremy Huddleston Sequoia <jeremyhu> | ||||
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | fpizlo, mcatanzaro, ossy | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| URL: | http://trac.macports.org/ticket/37740 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 126492 | ||||||
| Attachments: |
|
||||||
Please add changelog and set r? if you would like to ask review. Comment on attachment 220146 [details]
patch to check ruby version first
This looks fine. Can you prepare-ChangeLog and resubmit the patch? I'll be happy to r+ with appropriate ChangeLog text.
ping (In reply to comment #3) > ping Do you want to do the honors and land this with a changelog? R=me. Looks like 1.8.7 is the minimum required nowadays, so closing. |
Created attachment 220146 [details] patch to check ruby version first You should use getc on older ruby (or update configure to abort if ruby is older than 1.8.7) Trivial patch attached.