Summary: | [GTK] Use libc++ for C++11 on darwin | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jeremy Huddleston Sequoia <jeremyhu> | ||||||
Component: | WebKitGTK | Assignee: | Zan Dobersek <zan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cgarcia, mcatanzaro, zan | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 126492, 126431 | ||||||||
Attachments: |
|
Description
Jeremy Huddleston Sequoia
2013-12-30 21:15:24 PST
I think we can switch to libc++ on all platforms when compiling with Clang. Some distributions (e.g. Fedora) ship Clang but not libc++. I think we could default to libc++ on Darwin and stop passing the -stdlib option to the Clang compiler on other platforms. The option could still be enforced manually through the CXXFLAGS env. Created attachment 220392 [details]
Patch
My one suggestion is that you don't add -stdlib=libc++ if CXXFLAGS already contains "-stdlib=" Created attachment 220396 [details]
Patch
Comment on attachment 220396 [details]
Patch
I'm actually a bit surprised we need the standard library.
Comment on attachment 220396 [details] Patch Clearing flags on attachment: 220396 Committed r161333: <http://trac.webkit.org/changeset/161333> All reviewed patches have been landed. Closing bug. |