| Summary: | Tools/gtk/generate-feature-defines-files doesn't work with older versions of python | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jeremy Huddleston Sequoia <jeremyhu> | ||||
| Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, evab.u-szeged, galpeter, ossy | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 221256 [details]
Patch
LGTM Comment on attachment 221256 [details]
Patch
r=me
Comment on attachment 221256 [details] Patch Clearing flags on attachment: 221256 Committed r162125: <http://trac.webkit.org/changeset/162125> All reviewed patches have been landed. Closing bug. |
With Leopard's python (2.5.1), this script fails: Tools/gtk/generate-feature-defines-files Tools/gtk/generate-feature-defines-files:13: Warning: 'with' will become a reserved keyword in Python 2.6 File "Tools/gtk/generate-feature-defines-files", line 13 with open(feature_defines_overriding_file) as f: ^ SyntaxError: invalid syntax This causes build failures down the line due to missing headers. You should have this cause an error during configure.