Bug 126323

Summary:

Tools/gtk/generate-feature-defines-files doesn't work with older versions of python

Product:

WebKit

Reporter:

Jeremy Huddleston Sequoia <jeremyhu>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, evab.u-szeged, galpeter, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Jeremy Huddleston Sequoia

Reported 2013-12-30 21:10:59 PST

With Leopard's python (2.5.1), this script fails: Tools/gtk/generate-feature-defines-files Tools/gtk/generate-feature-defines-files:13: Warning: 'with' will become a reserved keyword in Python 2.6 File "Tools/gtk/generate-feature-defines-files", line 13 with open(feature_defines_overriding_file) as f: ^ SyntaxError: invalid syntax This causes build failures down the line due to missing headers. You should have this cause an error during configure.

Attachments
Patch (1.04 KB, patch) 2014-01-15 03:49 PST, Éva Balázsfalvi	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Éva Balázsfalvi

Comment 1 2014-01-15 03:49:56 PST

Created attachment 221256 [details] Patch

Peter Gal

Comment 2 2014-01-16 01:23:56 PST

LGTM

Csaba Osztrogonác

Comment 3 2014-01-16 06:44:31 PST

Comment on attachment 221256 [details] Patch r=me

WebKit Commit Bot

Comment 4 2014-01-16 06:56:52 PST

Comment on attachment 221256 [details] Patch Clearing flags on attachment: 221256 Committed r162125: <http://trac.webkit.org/changeset/162125>

WebKit Commit Bot

Comment 5 2014-01-16 06:56:54 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.