Bug 126308

Summary: Move more of Connection over to STL threading primitives
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: REOPENED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 126332    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Anders Carlsson
Reported 2013-12-30 15:22:51 PST
Move more of Connection over to STL threading primitives
Attachments
Patch (5.23 KB, patch)
2013-12-30 15:25 PST, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-12-30 15:25:16 PST
Created attachment 220130 [details] Patch
WebKit Commit Bot
Comment 2 2013-12-30 15:28:16 PST
Attachment 220130 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Platform/IPC/Connection.cpp', '--commit-queue']" exit_code: 1 ERROR: Source/WebKit2/Platform/IPC/Connection.cpp:60: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3 2013-12-30 15:36:26 PST
Comment on attachment 220130 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220130&action=review r=me > Source/WebKit2/Platform/IPC/Connection.cpp:597 > - timedOut = currentTime() >= absoluteTime; > + timedOut = std::chrono::steady_clock::now() >= timeoutTime; Oh god why.
Anders Carlsson
Comment 4 2013-12-30 15:42:51 PST
Committed r161157: <http://trac.webkit.org/changeset/161157>
WebKit Commit Bot
Comment 5 2013-12-30 22:47:23 PST
Re-opened since this is blocked by bug 126332
Alexey Proskuryakov
Comment 6 2013-12-30 22:49:41 PST
Comment on attachment 220130 [details] Patch Rolling out, because Mountain Lion is still broken after follow-up fixes: http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK2%20(Tests)?numbuilds=50
Note You need to log in before you can comment on or make changes to this bug.