| Summary: | Move more of Connection over to STL threading primitives | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
| Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
| Status: | REOPENED --- | ||||||
| Severity: | Normal | CC: | commit-queue | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 126332 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Anders Carlsson
2013-12-30 15:22:51 PST
Created attachment 220130 [details]
Patch
Attachment 220130 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Platform/IPC/Connection.cpp', '--commit-queue']" exit_code: 1
ERROR: Source/WebKit2/Platform/IPC/Connection.cpp:60: More than one command on the same line [whitespace/newline] [4]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 220130 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220130&action=review r=me > Source/WebKit2/Platform/IPC/Connection.cpp:597 > - timedOut = currentTime() >= absoluteTime; > + timedOut = std::chrono::steady_clock::now() >= timeoutTime; Oh god why. Committed r161157: <http://trac.webkit.org/changeset/161157> Re-opened since this is blocked by bug 126332 Comment on attachment 220130 [details] Patch Rolling out, because Mountain Lion is still broken after follow-up fixes: http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK2%20(Tests)?numbuilds=50 |