Bug 126308 - Move more of Connection over to STL threading primitives
Summary: Move more of Connection over to STL threading primitives
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
Depends on: 126332
  Show dependency treegraph
Reported: 2013-12-30 15:22 PST by Anders Carlsson
Modified: 2013-12-30 22:49 PST (History)
1 user (show)

See Also:

Patch (5.23 KB, patch)
2013-12-30 15:25 PST, Anders Carlsson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-12-30 15:22:51 PST
Move more of Connection over to STL threading primitives
Comment 1 Anders Carlsson 2013-12-30 15:25:16 PST
Created attachment 220130 [details]
Comment 2 WebKit Commit Bot 2013-12-30 15:28:16 PST
Attachment 220130 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Platform/IPC/Connection.cpp', '--commit-queue']" exit_code: 1
ERROR: Source/WebKit2/Platform/IPC/Connection.cpp:60:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 2 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2013-12-30 15:36:26 PST
Comment on attachment 220130 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=220130&action=review


> Source/WebKit2/Platform/IPC/Connection.cpp:597
> -            timedOut = currentTime() >= absoluteTime;
> +            timedOut = std::chrono::steady_clock::now() >= timeoutTime;

Oh god why.
Comment 4 Anders Carlsson 2013-12-30 15:42:51 PST
Committed r161157: <http://trac.webkit.org/changeset/161157>
Comment 5 WebKit Commit Bot 2013-12-30 22:47:23 PST
Re-opened since this is blocked by bug 126332
Comment 6 Alexey Proskuryakov 2013-12-30 22:49:41 PST
Comment on attachment 220130 [details]

Rolling out, because Mountain Lion is still broken after follow-up fixes: