Bug 126295

Summary: REGRESSION (r157443): Search fields with a non-white background don’t have a round bezel
Product: WebKit Reporter: mitz
Component: FormsAssignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: adele, bunhere, cdumez, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, kondapallykalyan, rniwa, sergio, simon.fraser, webkit-bug-importer
Priority: P1 Keywords: InRadar, Regression
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: data:text/html,<input%20type=search%20style="background-color:%20lightblue;">
Attachments:
Description Flags
Revert r157443 rniwa: review+

mitz
Reported 2013-12-30 10:14:06 PST
To reproduce, navigate to the URL. The search field doesn’t have the characteristic pill shape. This was caused by <http://trac.webkit.org/r157443>, the change made for bug 119967. We can’t just treat search fields as style-able without writing the code to render them properly when styled. Moreover, as this change broke various webpages that (either intentionally or accidentally) applied style to search fields, even when we make them style-able we may need to do so in some a backwards-compatible manner.
Attachments
Revert r157443 (14.63 KB, patch)
2014-02-14 16:44 PST, mitz 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2013-12-30 10:28:27 PST
<rdar://problem/15732820>
mitz
Comment 2 2014-02-14 16:44:06 PST
Created attachment 224264 [details] Revert r157443
Anders Carlsson
Comment 3 2014-02-14 16:50:48 PST
Comment on attachment 224264 [details] Revert r157443 View in context: https://bugs.webkit.org/attachment.cgi?id=224264&action=review > Source/WebCore/rendering/RenderTheme.cpp:688 > + // FIXME: Uncomment this when making search fields style-able. > + // case SearchFieldPart: Maybe just get rid of the commented out case statement and change the comment to say that SearchFieldPart should be handled here when making search fields style-able?
mitz
Comment 4 2014-02-14 16:55:18 PST
Fixed in <http://trac.webkit.org/r164145>.
mitz
Comment 6 2014-02-14 20:02:41 PST
(In reply to comment #5) > This broke a test: http://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK1%20(Tests)/r164149%20(2979)/results.html Looking into this.
Ryosuke Niwa
Comment 7 2014-02-14 20:23:49 PST
Rebaselined the test in http://trac.webkit.org/changeset/164154 since the pixel result looked just fine.
Ryosuke Niwa
Comment 8 2014-02-14 20:25:35 PST
(In reply to comment #7) > Rebaselined the test in http://trac.webkit.org/changeset/164154 since the pixel result looked just fine. Oops, I forgot to add the old results to mac-mountainlion. Doing that now.
Ryosuke Niwa
Comment 9 2014-02-14 20:28:31 PST
Done that in http://trac.webkit.org/changeset/164155.
Note You need to log in before you can comment on or make changes to this bug.