Bug 126287

Summary:

[SOUP] Return early in ResourceHandle::receivedCancellation if the load has already cancelled

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, danw, gustavo, mrobinson, rakuco, svillar

Priority:

Keywords:

Soup

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mrobinson: review+

Description Carlos Garcia Campos 2013-12-30 03:41:30 PST

This situation can happen when using the network process, because the ReceivedCancellation message can be received when the resource loader has already been removed, but the authentication challenge still has a reference to the ResourceHandleClient. 

$ WEBKIT_USE_NETWORK_PROCESS=1 Programs/WebKit2APITests/TestAuthentication 
/webkit2/WebKitWebView/authentication-request: OK
/webkit2/WebKitWebView/authentication-cancel: OK
/webkit2/WebKitWebView/authentication-load-cancelled: 
(process:1716): libsoup-CRITICAL **: soup_session_unpause_message: assertion 'item != NULL' failed
OK
/webkit2/WebKitWebView/authentication-failure: OK
/webkit2/WebKitWebView/authentication-no-credential: OK
/webkit2/WebKitWebView/authentication-storage: 
(process:1843): libsoup-CRITICAL **: soup_session_unpause_message: assertion 'item != NULL' failed

Comment 1 Carlos Garcia Campos 2013-12-30 03:45:06 PST

Created attachment 220106 [details]
Patch

Comment 2 Carlos Garcia Campos 2013-12-31 00:31:03 PST

Committed r161179: <http://trac.webkit.org/changeset/161179>