| Summary: | Attempt to fix the build of WebCore's code generator on CMake based system | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||
| Component: | New Bugs | Assignee: | Benjamin Poulain <benjamin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, dbates, gyuyoung.kim, gyuyoung.kim, laszlo.gombos, mrobinson, rakuco | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Benjamin Poulain
2013-12-28 05:14:22 PST
Created attachment 220073 [details]
Patch
Comment on attachment 220073 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220073&action=review > Source/JavaScriptCore/ChangeLog:3 > + Attempt to fix the build of WebCore's code generator on CMake based system Can you elaborate? Do we know what revision broke the build? Or is this more of a correctness issue than a build fix? As of the time of writing, looking at <http://build.webkit.org/console> and the stdio of the compile step on EFL Linux 64-bit Release WK1/WK2 and GTK Linux 64-bit Debug WK1/Release, the bots seem to be building without any JavaScriptCore header-related errors. (In reply to comment #2) > (From update of attachment 220073 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=220073&action=review > > > Source/JavaScriptCore/ChangeLog:3 > > + Attempt to fix the build of WebCore's code generator on CMake based system > > Can you elaborate? Do we know what revision broke the build? Or is this more of a correctness issue than a build fix? As of the time of writing, looking at <http://build.webkit.org/console> and the stdio of the compile step on EFL Linux 64-bit Release WK1/WK2 and GTK Linux 64-bit Debug WK1/Release, the bots seem to be building without any JavaScriptCore header-related errors. I am trying to fix the build consistency to land https://bugs.webkit.org/show_bug.cgi?id=126185 Committed r161206: <http://trac.webkit.org/changeset/161206> |