Merge didMoveOnscreen / page visibility to isVisible

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Gavin Barraclough]

The onscreen state most closely tracks view visibility (though currently also tracks a mix of in-window state). Make more consistent, simplify, and move all animation suspension logic to Page, so it can be controlled by the PageThrottler.

[Gavin Barraclough]

Created attachment 220067 [details]
Early patch for EWS

[EFL EWS Bot]

Comment on attachment 220067 [details]
Early patch for EWS

Attachment 220067 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/6298945886093312

[Gavin Barraclough]

Created attachment 220069 [details]
Fix

[Tim Horton]

Comment on attachment 220069 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=220069&action=review

> Source/WebCore/page/Page.cpp:1223
> +    if (isVisible)
> +        m_isPrerender = false;
> +
> +    if (isVisible) {

why are there two if() blocks with the same condition here?

> Source/WebCore/page/Page.cpp:1263
> +        suspendScriptedAnimations();

space above here

[Gavin Barraclough]

Fixed in r161223

[Alexey Proskuryakov]

Build fix in r161224.