Bug 126268

Summary: Merge didMoveOnscreen / page visibility to isVisible
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: WebCore Misc.Assignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: eflews.bot, gyuyoung.kim
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Early patch for EWS
eflews.bot: commit-queue-
Fix thorton: review+

Gavin Barraclough
Reported 2013-12-27 16:16:19 PST
The onscreen state most closely tracks view visibility (though currently also tracks a mix of in-window state). Make more consistent, simplify, and move all animation suspension logic to Page, so it can be controlled by the PageThrottler.
Attachments
Early patch for EWS (18.19 KB, patch)
2013-12-27 16:18 PST, Gavin Barraclough 		eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Fix (25.56 KB, patch)
2013-12-27 22:21 PST, Gavin Barraclough 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2013-12-27 16:18:17 PST
Created attachment 220067 [details] Early patch for EWS
EFL EWS Bot
Comment 2 2013-12-27 16:27:51 PST
Comment on attachment 220067 [details] Early patch for EWS Attachment 220067 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/6298945886093312
Gavin Barraclough
Comment 3 2013-12-27 22:21:03 PST
Created attachment 220069 [details] Fix
Tim Horton
Comment 4 2014-01-02 11:51:09 PST
Comment on attachment 220069 [details] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=220069&action=review > Source/WebCore/page/Page.cpp:1223 > + if (isVisible) > + m_isPrerender = false; > + > + if (isVisible) { why are there two if() blocks with the same condition here? > Source/WebCore/page/Page.cpp:1263 > + suspendScriptedAnimations(); space above here
Gavin Barraclough
Comment 5 2014-01-02 14:02:50 PST
Fixed in r161223
Alexey Proskuryakov
Comment 6 2014-01-02 14:12:37 PST
Build fix in r161224.
Note You need to log in before you can comment on or make changes to this bug.