Bug 126247

Summary: WebKitGtk 2 build fails from git
Product: WebKit Reporter: Giovanni Campagna <scampa.giovanni>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, changseok, commit-queue, gustavo, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Giovanni Campagna
Reported 2013-12-26 14:52:58 PST
Since the recent enablement of the NetworkProcess in the standard WebKitGtk build, the build fails because libwebkitgtk2 does not expose NetworkProcessMain (so linking WebKitNetworkProcess fails). This only happens if the symbol filter is enabled, ie if not --enable-developer-mode. The simple fix is: diff --git a/Source/autotools/symbols.filter b/Source/autotools/symbols.filter index a01a00c..81a9725 100644 --- a/Source/autotools/symbols.filter +++ b/Source/autotools/symbols.filter @@ -2,6 +2,7 @@ global: webkit_*; WebProcessMainGtk; + NetworkProcessMain; _ZN6WebKit22WebGtkExtensionManager10initializeEPK14OpaqueWKBundlePKv; _ZN6WebKit22WebGtkExtensionManager6sharedEv; local: I can prepare a proper patch with the usual conventions, but it looks trivial enough that someone of you can apply it (I don't have commit access anyway). Thanks!
Attachments
Patch (1.03 KB, patch)
2013-12-27 15:17 PST, Giovanni Campagna 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2013-12-27 01:57:55 PST
Feel free to upload the proper patch, someone else can commit it for you or through the commit queue (the automated commit bot for reviewed patches).
ChangSeok Oh
Comment 2 2013-12-27 07:45:48 PST
*** Bug 126241 has been marked as a duplicate of this bug. ***
ChangSeok Oh
Comment 3 2013-12-27 07:49:35 PST
(In reply to comment #0) > Since the recent enablement of the NetworkProcess in the standard WebKitGtk build, the build fails because libwebkitgtk2 does not expose NetworkProcessMain (so linking WebKitNetworkProcess fails). This only happens if the symbol filter is enabled, ie if not --enable-developer-mode. > > The simple fix is: > > diff --git a/Source/autotools/symbols.filter b/Source/autotools/symbols.filter > index a01a00c..81a9725 100644 > --- a/Source/autotools/symbols.filter > +++ b/Source/autotools/symbols.filter > @@ -2,6 +2,7 @@ > global: > webkit_*; > WebProcessMainGtk; > + NetworkProcessMain; > _ZN6WebKit22WebGtkExtensionManager10initializeEPK14OpaqueWKBundlePKv; > _ZN6WebKit22WebGtkExtensionManager6sharedEv; > local: > > I can prepare a proper patch with the usual conventions, but it looks trivial enough that someone of you can apply it (I don't have commit access anyway). Please go ahead. Sooner is better :)
Giovanni Campagna
Comment 4 2013-12-27 15:17:19 PST
Created attachment 220065 [details] Patch
WebKit Commit Bot
Comment 5 2013-12-28 00:54:34 PST
Comment on attachment 220065 [details] Patch Clearing flags on attachment: 220065 Committed r161110: <http://trac.webkit.org/changeset/161110>
WebKit Commit Bot
Comment 6 2013-12-28 00:54:36 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.