Bug 126234

Summary:

Some links at build.webkit.org/dashboard don't show status messages, and aren't keyboard accessible

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed fix	timothy: review+

Alexey Proskuryakov

Reported 2013-12-25 15:04:56 PST

I think that we could use <a> for links, not <div>.

Attachments
proposed fix (6.41 KB, patch) 2013-12-25 15:17 PST, Alexey Proskuryakov	timothy: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2013-12-25 15:17:29 PST

Created attachment 220004 [details] proposed fix I think that this makes the code noticeably simpler, although I do not know if forcing display:block is a good idea. Without display:block, the label line becomes a few pixels higher, breaking layout. Is there another way around that?

Alexey Proskuryakov

Comment 2 2013-12-26 11:17:07 PST

Committed <http://trac.webkit.org/r161092>.

Note You need to log in before you can comment on or make changes to this bug.