Bug 126230

Summary: [Nix] Adding createDragImageIconForCachedImageFilename method to DragImageNix
Product: WebKit Reporter: Thiago de Barros Lacerda <thiago.lacerda>
Component: WebCore Misc.Assignee: Thiago de Barros Lacerda <thiago.lacerda>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, ossy, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
dbates: review+
Patch for landing none

Description Thiago de Barros Lacerda 2013-12-25 10:43:40 PST 
[Nix] Adding createDragImageIconForCachedImageFilename to DragImageNix
Comment 1 Thiago de Barros Lacerda 2013-12-25 10:46:41 PST 
Created attachment 219996 [details]
Patch
Comment 2 Daniel Bates 2013-12-25 15:43:06 PST 
Comment on attachment 219996 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219996&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests needed.

Either remove this line or explain why "no new tests [are] needed". It seems obvious that no new tests are needed as this patch is adding a function that is materially consistent with an empty function.

> Source/WebCore/platform/nix/DragImageNix.cpp:73
> +    return 0;

Nit: 0 => nullptr
Comment 3 Thiago de Barros Lacerda 2013-12-25 18:26:35 PST 
Created attachment 220018 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2013-12-25 19:00:21 PST 
Comment on attachment 220018 [details]
Patch for landing

Clearing flags on attachment: 220018

Committed r161081: <http://trac.webkit.org/changeset/161081>
Comment 5 Philippe Normand 2013-12-26 01:38:00 PST 
This can be closed I suppose.