| Summary: | [Nix] Fixing DragData::asFragment signature in DragDataNix.cpp | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Thiago de Barros Lacerda <thiago.lacerda> | ||||||
| Component: | WebCore Misc. | Assignee: | Thiago de Barros Lacerda <thiago.lacerda> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, dbates, ossy | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Thiago de Barros Lacerda
2013-12-25 10:39:34 PST
Created attachment 219995 [details]
Patch
Comment on attachment 219995 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219995&action=review > Source/WebCore/ChangeLog:8 > + No new tests needed. Either remove this line or explain why "no new tests [are] needed". It seems obvious that no new tests are needed as this patch is a build fix. > Source/WebCore/platform/nix/DragDataNix.cpp:90 > return 0; Nit: 0 => nullptr (In reply to comment #2) > (From update of attachment 219995 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=219995&action=review > > > Source/WebCore/ChangeLog:8 > > + No new tests needed. > > Either remove this line or explain why "no new tests [are] needed". It seems obvious that no new tests are needed as this patch is a build fix. OK > > > Source/WebCore/platform/nix/DragDataNix.cpp:90 > > return 0; > > Nit: 0 => nullptr OK Created attachment 220017 [details]
Patch for landing
Comment on attachment 220017 [details] Patch for landing Clearing flags on attachment: 220017 Committed r161080: <http://trac.webkit.org/changeset/161080> |