Bug 126204

Summary: CStack Branch: throwExceptionFromCallSlowPathGenerator() shouldn't pop frame
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 126172    
Attachments:
Description Flags
Patch
fpizlo: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion
none
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion none

Description Michael Saboff 2013-12-23 22:35:37 PST
Given that the calling convention pushes and pops the call frame register, there is no need to pop a call frame in throwExceptionFromCallSlowPathGenerator().
Comment 1 Michael Saboff 2013-12-23 22:36:39 PST
This bug is responsible for most of the remaining C Stack test failures.
Comment 2 Michael Saboff 2013-12-23 22:41:32 PST
Created attachment 219957 [details]
Patch

This fixes most of the remaining bugs.
Comment 3 Build Bot 2013-12-24 02:53:45 PST
Comment on attachment 219957 [details]
Patch

Attachment 219957 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/49048106

New failing tests:
js/dfg-exception.html
js/exception-propagate-from-dfg-to-llint.html
webgl/1.0.1/conformance/misc/instanceof-test.html
fast/canvas/webgl/instanceof-test.html
fast/canvas/webgl/array-unit-tests.html
fast/dom/dom-constructors.html
fast/canvas/webgl/arraybuffer-transfer-of-control.html
js/dom/stack-trace.html
fast/dom/unregister-protocol-handler.html
fast/dom/register-protocol-handler.html
fast/workers/shared-worker-constructor.html
webgl/1.0.1/conformance/typedarrays/array-unit-tests.html
webgl/1.0.2/conformance/misc/instanceof-test.html
js/dom/toString-and-valueOf-override.html
fast/workers/worker-constructor.html
Comment 4 Build Bot 2013-12-24 02:53:46 PST
Created attachment 219960 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 5 Build Bot 2013-12-24 03:38:55 PST
Comment on attachment 219957 [details]
Patch

Attachment 219957 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/51288145

New failing tests:
js/dfg-exception.html
js/exception-propagate-from-dfg-to-llint.html
webgl/1.0.1/conformance/misc/instanceof-test.html
fast/canvas/webgl/instanceof-test.html
fast/canvas/webgl/array-unit-tests.html
fast/dom/dom-constructors.html
fast/canvas/webgl/arraybuffer-transfer-of-control.html
js/dom/stack-trace.html
fast/dom/unregister-protocol-handler.html
fast/dom/register-protocol-handler.html
fast/workers/shared-worker-constructor.html
webgl/1.0.1/conformance/typedarrays/array-unit-tests.html
webgl/1.0.2/conformance/misc/instanceof-test.html
js/dom/toString-and-valueOf-override.html
fast/workers/worker-constructor.html
Comment 6 Build Bot 2013-12-24 03:38:56 PST
Created attachment 219963 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 7 Michael Saboff 2013-12-24 07:28:58 PST
Committed r161057: <http://trac.webkit.org/changeset/161057>