Bug 126196

Summary: Add the pseudo classes link and any-link to the Selector Code Generator
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, kangil.han, koivisto, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Benjamin Poulain
Reported 2013-12-23 17:47:56 PST
Add the pseudo classes link and any-link to the Selector Code Generator
Attachments
Patch (3.67 KB, patch)
2013-12-23 17:48 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2013-12-23 17:48:27 PST
Created attachment 219949 [details] Patch
Ryosuke Niwa
Comment 2 2013-12-23 18:36:40 PST
Comment on attachment 219949 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219949&action=review > Source/WebCore/dom/Node.h:566 > static ptrdiff_t nodeFlagsMemoryOffset() { return OBJECT_OFFSETOF(Node, m_nodeFlags); } > - static uint8_t flagIsElement() { return IsElementFlag; } > + static int32_t flagIsElement() { return IsElementFlag; } > + static int32_t flagIsLink() { return IsLinkFlag; } It's unfortunate that we have to expose flags... ideally we have some mechanism to assert that the flag condition we're checking is consistent with Node's implementation.
Benjamin Poulain
Comment 3 2013-12-23 19:25:27 PST
Comment on attachment 219949 [details] Patch Clearing flags on attachment: 219949 Committed r161046: <http://trac.webkit.org/changeset/161046>
Benjamin Poulain
Comment 4 2013-12-23 19:25:29 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.