Bug 126192

Summary: Add the experimental CSS code generator files to the remaining build systems
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, koivisto, rakuco, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Benjamin Poulain
Reported 2013-12-23 16:46:16 PST
Add the experimental CSS code generator files to the remaining build systems
Attachments
Patch (5.70 KB, patch)
2013-12-23 16:46 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (5.25 KB, patch)
2013-12-23 17:56 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2013-12-23 16:46:32 PST
Created attachment 219942 [details] Patch
WebKit Commit Bot
Comment 2 2013-12-23 16:48:13 PST
Attachment 219942 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/CMakeLists.txt:29: There should be exactly one empty line instead of 0 between "inspector" and "loader/appcache". [list/emptyline] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Benjamin Poulain
Comment 3 2013-12-23 17:53:35 PST
Comment on attachment 219942 [details] Patch I am a dumbass, wrong tree.
Benjamin Poulain
Comment 4 2013-12-23 17:56:41 PST
Created attachment 219950 [details] Patch
WebKit Commit Bot
Comment 5 2013-12-23 17:59:32 PST
Attachment 219950 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/CMakeLists.txt:29: There should be exactly one empty line instead of 0 between "inspector" and "loader/appcache". [list/emptyline] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Benjamin Poulain
Comment 6 2013-12-23 19:19:50 PST
Comment on attachment 219950 [details] Patch Clearing flags on attachment: 219950 Committed r161044: <http://trac.webkit.org/changeset/161044>
Benjamin Poulain
Comment 7 2013-12-23 19:19:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.