| Summary: | Add the experimental CSS code generator files to the remaining build systems | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||||
| Component: | New Bugs | Assignee: | Benjamin Poulain <benjamin> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, gyuyoung.kim, koivisto, rakuco, rniwa | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Benjamin Poulain
2013-12-23 16:46:16 PST
Created attachment 219942 [details]
Patch
Attachment 219942 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/CMakeLists.txt:29: There should be exactly one empty line instead of 0 between "inspector" and "loader/appcache". [list/emptyline] [5]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 219942 [details]
Patch
I am a dumbass, wrong tree.
Created attachment 219950 [details]
Patch
Attachment 219950 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/CMakeLists.txt:29: There should be exactly one empty line instead of 0 between "inspector" and "loader/appcache". [list/emptyline] [5]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 219950 [details] Patch Clearing flags on attachment: 219950 Committed r161044: <http://trac.webkit.org/changeset/161044> All reviewed patches have been landed. Closing bug. |