Bug 126191

Summary: CStack:Fixed JSStack::disableErrorStackReserve() and JSStack::installTrapsAfterFrame()
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: fpizlo, ggaren, mhahnenberg, msaboff, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 125849    
Attachments:
Description Flags
the patch. none

Mark Lam
Reported 2013-12-23 16:39:49 PST
1. JSStack::disableErrorStackReserve() was wrongly comparing m_end with m_useableTop. Fixed the comparison. 2. JSStack::installTrapsAfterFrame() is wrongly overwriting the top slow of the top frame. Fixed to start the traps at the slot below (as in at lower memory than) the top slot in the top frame.
Attachments
the patch. (2.45 KB, patch)
2013-12-23 16:45 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2013-12-23 16:45:04 PST
Created attachment 219941 [details] the patch.
Mark Lam
Comment 2 2013-12-23 16:46:50 PST
Landed in r161038 on the jsCStack branch: <http://trac.webkit.org/r161038>.
Filip Pizlo
Comment 3 2013-12-23 16:57:03 PST
Comment on attachment 219941 [details] the patch. Is it possible to have tests for this?
Mark Lam
Comment 4 2014-01-13 17:26:36 PST
Both JSStack::disableErrorStackReserve() and JSStack::installTrapsAfterFrame() were removed in r161927: <http://trac.webkit.org/r161927> for https://bugs.webkit.org/show_bug.cgi?id=126790. This bug is no longer relevant. *** This bug has been marked as a duplicate of bug 126790 ***
Csaba Osztrogonác
Comment 5 2014-02-13 03:48:55 PST
Comment on attachment 219941 [details] the patch. Cleared review? from attachment 219941 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note You need to log in before you can comment on or make changes to this bug.