Bug 126189

Summary: Add the pseudo class :focus to the Selector Code Generator
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: koivisto, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch rniwa: review+

Description Benjamin Poulain 2013-12-23 16:18:30 PST 
Add the pseudo class :focus to the Selector Code Generator
Comment 1 Benjamin Poulain 2013-12-23 16:18:46 PST 
Created attachment 219940 [details]
Patch
Comment 2 Ryosuke Niwa 2013-12-23 16:30:36 PST 
Comment on attachment 219940 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219940&action=review

> Source/WebCore/cssjit/SelectorCompiler.cpp:244
> +            m_functionType = std::max(m_functionType, addPseudoType(selector->pseudoType(), fragment.pseudoClasses));

Maybe we should replace std::max with some descriptive inline function?
Or maybe addPseudoType should be a member function of SelectorCodeGenerator that auto-updates m_functionType.
Or it should take m_functionType as an argument?
Comment 3 Benjamin Poulain 2013-12-23 17:19:41 PST 
Committed r161041: <http://trac.webkit.org/changeset/161041>