Bug 126189

Summary: Add the pseudo class :focus to the Selector Code Generator
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: koivisto, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch rniwa: review+

Benjamin Poulain
Reported 2013-12-23 16:18:30 PST
Add the pseudo class :focus to the Selector Code Generator
Attachments
Patch (4.82 KB, patch)
2013-12-23 16:18 PST, Benjamin Poulain 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2013-12-23 16:18:46 PST
Created attachment 219940 [details] Patch
Ryosuke Niwa
Comment 2 2013-12-23 16:30:36 PST
Comment on attachment 219940 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219940&action=review > Source/WebCore/cssjit/SelectorCompiler.cpp:244 > + m_functionType = std::max(m_functionType, addPseudoType(selector->pseudoType(), fragment.pseudoClasses)); Maybe we should replace std::max with some descriptive inline function? Or maybe addPseudoType should be a member function of SelectorCodeGenerator that auto-updates m_functionType. Or it should take m_functionType as an argument?
Benjamin Poulain
Comment 3 2013-12-23 17:19:41 PST
Committed r161041: <http://trac.webkit.org/changeset/161041>
Note You need to log in before you can comment on or make changes to this bug.