Bug 126187
| Summary: | Refactor PutPropertySlot to be aware of custom properties | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Oliver Hunt <oliver> |
| Component: | JavaScriptCore | Assignee: | Oliver Hunt <oliver> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap, commit-queue, rniwa |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 126240 | ||
| Bug Blocks: | |||
Oliver Hunt
Refactor PutPropertySlot to be aware of custom properties
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Oliver Hunt
Committed r161033: <http://trac.webkit.org/changeset/161033>
Ryosuke Niwa
Looks like this caused http/tests/security/cross-frame-access-put.html to start to fail:
http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fsecurity%2Fcross-frame-access-put.html
--- /Volumes/Data/slave/mountainlion-release-tests-wk1/build/layout-test-results/http/tests/security/cross-frame-access-put-expected.txt
+++ /Volumes/Data/slave/mountainlion-release-tests-wk1/build/layout-test-results/http/tests/security/cross-frame-access-put-actual.txt
@@ -1,5 +1,4 @@
CONSOLE MESSAGE: Blocked a frame with origin "http://localhost:8000" from accessing a frame with origin "http://127.0.0.1:8000". Protocols, domains, and ports must match.
-CONSOLE MESSAGE: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match.
CONSOLE MESSAGE: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match.
CONSOLE MESSAGE: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match.
CONSOLE MESSAGE: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match.
@@ -381,5 +380,6 @@
This test checks cross-frame access security of window attribute setters (rdar://problem/5326791).
+PASS: Unable to set property constructor: TypeError: Type error
MAIN WINDOW: !!-- Test ended--!!
Alexey Proskuryakov
Filed bug 126238 (although maybe it would be better to roll out?)
Oliver Hunt
(In reply to comment #3)
> Filed bug 126238 (although maybe it would be better to roll out?)
Honestly i don't think i'm going to get to this as soon as i though, so a rollout is probably best :(
WebKit Commit Bot
Re-opened since this is blocked by bug 126240
Alexey Proskuryakov
OK, rolled out in <http://trac.webkit.org/changeset/161077>.
Oliver Hunt
Committed r161220: <http://trac.webkit.org/changeset/161220>