| Summary: | Refactor PutPropertySlot to be aware of custom properties | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Oliver Hunt <oliver> |
| Component: | JavaScriptCore | Assignee: | Oliver Hunt <oliver> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap, commit-queue, rniwa |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 126240 | ||
| Bug Blocks: | |||
|
Description
Oliver Hunt
2013-12-23 15:55:13 PST
Committed r161033: <http://trac.webkit.org/changeset/161033> Looks like this caused http/tests/security/cross-frame-access-put.html to start to fail: http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fsecurity%2Fcross-frame-access-put.html --- /Volumes/Data/slave/mountainlion-release-tests-wk1/build/layout-test-results/http/tests/security/cross-frame-access-put-expected.txt +++ /Volumes/Data/slave/mountainlion-release-tests-wk1/build/layout-test-results/http/tests/security/cross-frame-access-put-actual.txt @@ -1,5 +1,4 @@ CONSOLE MESSAGE: Blocked a frame with origin "http://localhost:8000" from accessing a frame with origin "http://127.0.0.1:8000". Protocols, domains, and ports must match. -CONSOLE MESSAGE: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match. CONSOLE MESSAGE: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match. CONSOLE MESSAGE: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match. CONSOLE MESSAGE: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match. @@ -381,5 +380,6 @@ This test checks cross-frame access security of window attribute setters (rdar://problem/5326791). +PASS: Unable to set property constructor: TypeError: Type error MAIN WINDOW: !!-- Test ended--!! Filed bug 126238 (although maybe it would be better to roll out?) (In reply to comment #3) > Filed bug 126238 (although maybe it would be better to roll out?) Honestly i don't think i'm going to get to this as soon as i though, so a rollout is probably best :( Re-opened since this is blocked by bug 126240 OK, rolled out in <http://trac.webkit.org/changeset/161077>. Committed r161220: <http://trac.webkit.org/changeset/161220> |