Bug 126183

Summary: Remove boolean argument from Element::setChildrenAffectBy* methods
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Layout and RenderingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, benjamin, cmarcelo, commit-queue, dbates, esprehn+autocc, glenn, gyuyoung.kim, kangil.han, kling, koivisto, macpherson, menard
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Cleanup none

Description Ryosuke Niwa 2013-12-23 15:03:57 PST 
Remove boolean argument from Element::setChildrenAffectBy* methods
Comment 1 Ryosuke Niwa 2013-12-23 15:04:59 PST 
Created attachment 219933 [details]
Cleanup
Comment 2 Daniel Bates 2013-12-23 15:36:59 PST 
Comment on attachment 219933 [details]
Cleanup

We call setChildrenAffectedByActive(false), setChildrenAffectedByDrag(false) in ElementRareData::resetDynamicRestyleObservations(), <http://trac.webkit.org/browser/trunk/Source/WebCore/dom/ElementRareData.h?rev=159191#L225>
Comment 3 Daniel Bates 2013-12-23 15:42:42 PST 
Comment on attachment 219933 [details]
Cleanup

My bad. ElementRareData defines setChildrenAffectedByDrag()and setChildrenAffectedByActive().
Comment 4 WebKit Commit Bot 2013-12-23 16:45:03 PST 
Comment on attachment 219933 [details]
Cleanup

Clearing flags on attachment: 219933

Committed r161037: <http://trac.webkit.org/changeset/161037>
Comment 5 WebKit Commit Bot 2013-12-23 16:45:06 PST 
All reviewed patches have been landed.  Closing bug.