Bug 126183 - Remove boolean argument from Element::setChildrenAffectBy* methods
Summary: Remove boolean argument from Element::setChildrenAffectBy* methods
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks:
 
Reported: 2013-12-23 15:03 PST by Ryosuke Niwa
Modified: 2013-12-23 16:45 PST (History)
13 users (show)

See Also:

Attachments
Cleanup (4.53 KB, patch)
2013-12-23 15:04 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-12-23 15:03:57 PST 
Remove boolean argument from Element::setChildrenAffectBy* methods
Comment 1 Ryosuke Niwa 2013-12-23 15:04:59 PST 
Created attachment 219933 [details]
Cleanup
Comment 2 Daniel Bates 2013-12-23 15:36:59 PST 
Comment on attachment 219933 [details]
Cleanup

We call setChildrenAffectedByActive(false), setChildrenAffectedByDrag(false) in ElementRareData::resetDynamicRestyleObservations(), <http://trac.webkit.org/browser/trunk/Source/WebCore/dom/ElementRareData.h?rev=159191#L225>
Comment 3 Daniel Bates 2013-12-23 15:42:42 PST 
Comment on attachment 219933 [details]
Cleanup

My bad. ElementRareData defines setChildrenAffectedByDrag()and setChildrenAffectedByActive().
Comment 4 WebKit Commit Bot 2013-12-23 16:45:03 PST 
Comment on attachment 219933 [details]
Cleanup

Clearing flags on attachment: 219933

Committed r161037: <http://trac.webkit.org/changeset/161037>
Comment 5 WebKit Commit Bot 2013-12-23 16:45:06 PST 
All reviewed patches have been landed.  Closing bug.