| Summary: | CStack: Cosmetic: rename reservationEnd() to reservationTop() | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | fpizlo, ggaren, mhahnenberg, msaboff, oliver | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 125849 | ||||||
| Attachments: |
|
||||||
Created attachment 219932 [details]
the patch.
Landed in r161025 on the jsCStack branch: <http://trac.webkit.org/r161025>. Thanks for the review. Review status updated in r161039: <http://trac.webkit.org/r161039>. |
reservationEnd() computes the end of the stack at the top. The value is computed as: char* reservationEnd = static_cast<char*>(m_reservation.base()); return reinterpret_cast_ptr<Register*>(reservationEnd); Since m_reservation.base() points at a slot of memory that is within the allocatable range of the stack, this function reservationEnd() is inappropriate. Per Geoff's input, "end" usually refers to the slot past the end of a buffer. Calling it "top" is more appropriate. Hence, I will rename it to reservationTop().