Bug 126178

Summary: Use isDocumentFragment() instead of comparing nodeType() with Node::DOCUMENT_FRAGMENT_NODE
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, esprehn+autocc, kangil.han, kling, koivisto
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Cleanup none

Ryosuke Niwa
Reported 2013-12-23 13:41:58 PST
Inspired by https://chromium.googlesource.com/chromium/blink/+/a622cb80af2bfb0c5d91123cbcfa4fa72a06554c Node::isDocumentFragment() is faster than nodeType(), which is virtual.
Attachments
Cleanup (2.15 KB, patch)
2013-12-23 13:52 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-12-23 13:52:43 PST
Created attachment 219930 [details] Cleanup
WebKit Commit Bot
Comment 2 2013-12-23 14:47:55 PST
Comment on attachment 219930 [details] Cleanup Clearing flags on attachment: 219930 Committed r161024: <http://trac.webkit.org/changeset/161024>
WebKit Commit Bot
Comment 3 2013-12-23 14:47:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.