Bug 126171

Summary:

Update custom setter implementations to perform type checks

Product:

WebKit

Reporter:

Oliver Hunt <oliver>

Component:

New Bugs

Assignee:

Oliver Hunt <oliver>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alecflett, cdumez, cgarcia, commit-queue, jsbell

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	dbates: review+

Description Oliver Hunt 2013-12-23 11:34:43 PST

Update custom setter implementations to perform type checks

Comment 1 Oliver Hunt 2013-12-23 11:36:34 PST

Created attachment 219920 [details]
Patch

Comment 2 Daniel Bates 2013-12-23 11:45:52 PST

Comment on attachment 219920 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219920&action=review

This patch looks straightforward to me.

> Source/WebCore/ChangeLog:8
> +        Update the bindings codegen for setters so that they perform a real

Nit: codegen => code generator

> Source/WebCore/ChangeLog:9
> +        typecheck.

Nit: typecheck => type check

Comment 3 Oliver Hunt 2013-12-23 11:48:31 PST

Committed r161009: <http://trac.webkit.org/changeset/161009>