Bug 126171

Summary: Update custom setter implementations to perform type checks
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, cdumez, cgarcia, commit-queue, jsbell
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dbates: review+

Oliver Hunt
Reported 2013-12-23 11:34:43 PST
Update custom setter implementations to perform type checks
Attachments
Patch (98.02 KB, patch)
2013-12-23 11:36 PST, Oliver Hunt 		dbates: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2013-12-23 11:36:34 PST
Created attachment 219920 [details] Patch
Daniel Bates
Comment 2 2013-12-23 11:45:52 PST
Comment on attachment 219920 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219920&action=review This patch looks straightforward to me. > Source/WebCore/ChangeLog:8 > + Update the bindings codegen for setters so that they perform a real Nit: codegen => code generator > Source/WebCore/ChangeLog:9 > + typecheck. Nit: typecheck => type check
Oliver Hunt
Comment 3 2013-12-23 11:48:31 PST
Committed r161009: <http://trac.webkit.org/changeset/161009>
Note You need to log in before you can comment on or make changes to this bug.