Bug 126159

Summary: [CSS Blending] Log blending as a layer creation reason in the WI
Product: WebKit Reporter: Mihai Tica <mitica>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, mihnea, mitica, simon.fraser, timothy, webkit-bug-importer, WebkitBugTracker
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 99200    
Attachments:
Description Flags
[PATCH] Untested, Saved Draft of Proposed Fix
none
[PATCH] Proposed Fix
none
[IMAGE] Inspecting LayoutTests/css3/compositing/blend-mode-simple.html none

Mihai Tica
Reported 2013-12-23 06:02:32 PST
The 'blending' reason for compositing should be visible in the WI.
Attachments
[PATCH] Untested, Saved Draft of Proposed Fix (4.45 KB, patch)
2014-01-09 11:12 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (4.49 KB, patch)
2014-01-10 10:48 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[IMAGE] Inspecting LayoutTests/css3/compositing/blend-mode-simple.html (173.40 KB, image/png)
2014-01-10 10:49 PST, Joseph Pecoraro 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-12-23 06:03:14 PST
<rdar://problem/15718597>
Radar WebKit Bug Importer
Comment 2 2013-12-23 06:03:20 PST
<rdar://problem/15718599>
Timothy Hatcher
Comment 3 2014-01-09 10:53:28 PST
*** Bug 126706 has been marked as a duplicate of this bug. ***
Joseph Pecoraro
Comment 4 2014-01-09 11:04:40 PST
I'm working on this now.
Joseph Pecoraro
Comment 5 2014-01-09 11:09:37 PST
The originator: <https://webkit.org/b/99200> Add support for blendmode to Core Animation layer Hasn't landed yet. When it does I'll have a patch.
Joseph Pecoraro
Comment 6 2014-01-09 11:12:00 PST
Created attachment 220752 [details] [PATCH] Untested, Saved Draft of Proposed Fix
Mihai Tica
Comment 7 2014-01-10 05:12:59 PST
(In reply to comment #5) > The originator: > <https://webkit.org/b/99200> Add support for blendmode to Core Animation layer > > Hasn't landed yet. When it does I'll have a patch. Thanks! The dependency patch has landed, this issue is no longer blocked.
Joseph Pecoraro
Comment 8 2014-01-10 10:48:54 PST
Created attachment 220858 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 9 2014-01-10 10:49:26 PST
Created attachment 220859 [details] [IMAGE] Inspecting LayoutTests/css3/compositing/blend-mode-simple.html
Timothy Hatcher
Comment 10 2014-01-10 10:51:32 PST
Comment on attachment 220858 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=220858&action=review > Source/WebInspectorUI/UserInterface/LayerTreeSidebarPanel.js:432 > + addReason(WebInspector.UIString("Element has âblend-modeâ style")); Why do we use longer and more vague descriptions in WebCore ("due to association with") and in the UI we are more matter of fact?
WebKit Commit Bot
Comment 11 2014-01-10 13:39:20 PST
Comment on attachment 220858 [details] [PATCH] Proposed Fix Clearing flags on attachment: 220858 Committed r161673: <http://trac.webkit.org/changeset/161673>
WebKit Commit Bot
Comment 12 2014-01-10 13:39:23 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.