Bug 126159

Summary: [CSS Blending] Log blending as a layer creation reason in the WI
Product: WebKit Reporter: Mihai Tica <mitica>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, mihnea, mitica, simon.fraser, timothy, webkit-bug-importer, WebkitBugTracker
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 99200    
Attachments:
Description Flags
[PATCH] Untested, Saved Draft of Proposed Fix
none
[PATCH] Proposed Fix
none
[IMAGE] Inspecting LayoutTests/css3/compositing/blend-mode-simple.html none

Description Mihai Tica 2013-12-23 06:02:32 PST 
The 'blending' reason for compositing should be visible in the WI.
Comment 1 Radar WebKit Bug Importer 2013-12-23 06:03:14 PST 
<rdar://problem/15718597>
Comment 2 Radar WebKit Bug Importer 2013-12-23 06:03:20 PST 
<rdar://problem/15718599>
Comment 3 Timothy Hatcher 2014-01-09 10:53:28 PST 
*** Bug 126706 has been marked as a duplicate of this bug. ***
Comment 4 Joseph Pecoraro 2014-01-09 11:04:40 PST 
I'm working on this now.
Comment 5 Joseph Pecoraro 2014-01-09 11:09:37 PST 
The originator:
<https://webkit.org/b/99200> Add support for blendmode to Core Animation layer

Hasn't landed yet. When it does I'll have a patch.
Comment 6 Joseph Pecoraro 2014-01-09 11:12:00 PST 
Created attachment 220752 [details]
[PATCH] Untested, Saved Draft of Proposed Fix
Comment 7 Mihai Tica 2014-01-10 05:12:59 PST 
(In reply to comment #5)
> The originator:
> <https://webkit.org/b/99200> Add support for blendmode to Core Animation layer
> 
> Hasn't landed yet. When it does I'll have a patch.

Thanks!
The dependency patch has landed, this issue is no longer blocked.
Comment 8 Joseph Pecoraro 2014-01-10 10:48:54 PST 
Created attachment 220858 [details]
[PATCH] Proposed Fix
Comment 9 Joseph Pecoraro 2014-01-10 10:49:26 PST 
Created attachment 220859 [details]
[IMAGE] Inspecting LayoutTests/css3/compositing/blend-mode-simple.html
Comment 10 Timothy Hatcher 2014-01-10 10:51:32 PST 
Comment on attachment 220858 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=220858&action=review

> Source/WebInspectorUI/UserInterface/LayerTreeSidebarPanel.js:432
> +            addReason(WebInspector.UIString("Element has âblend-modeâ style"));

Why do we use longer and more vague descriptions in WebCore ("due to association with") and in the UI we are more matter of fact?
Comment 11 WebKit Commit Bot 2014-01-10 13:39:20 PST 
Comment on attachment 220858 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 220858

Committed r161673: <http://trac.webkit.org/changeset/161673>
Comment 12 WebKit Commit Bot 2014-01-10 13:39:23 PST 
All reviewed patches have been landed.  Closing bug.