Bug 126128

Summary: [GTK] Build with network process unconditionally
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, gustavo, mrobinson, philn, xan.lopez, zan
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 125422    
Bug Blocks:    
Attachments:
Description Flags
Patch
mrobinson: review+
Patch for landing none

Carlos Garcia Campos
Reported 2013-12-22 02:00:13 PST
The decision to use the network process is made at run time, so we can always build with the network process with no risk. This will help to catch build issues only affecting the network process and will also make a lot easier to work on the network process if we make the decision based on a env variable until we have the proper API.
Attachments
Patch (6.74 KB, patch)
2013-12-22 02:07 PST, Carlos Garcia Campos 		mrobinson: review+
DetailsFormatted DiffDiff
Patch for landing (6.81 KB, patch)
2013-12-23 00:41 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2013-12-22 02:07:29 PST
Created attachment 219867 [details] Patch
WebKit Commit Bot
Comment 2 2013-12-22 02:09:21 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Carlos Garcia Campos
Comment 3 2013-12-22 02:22:52 PST
I doesn't build because it depends on bug #125422
Carlos Garcia Campos
Comment 4 2013-12-23 00:41:22 PST
Created attachment 219899 [details] Patch for landing Patch for EWS, to make sure I haven't broken EFL build
Carlos Garcia Campos
Comment 5 2013-12-23 01:04:29 PST
Committed r160989: <http://trac.webkit.org/changeset/160989>
Note You need to log in before you can comment on or make changes to this bug.