Bug 126126

Summary:

REGRESSION (r160672): Random remote layers are getting shadows

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

Layout and Rendering

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	andersca: review+

Description Tim Horton 2013-12-21 21:46:23 PST

In http://trac.webkit.org/changeset/160672, we unconditionally check m_properties.customAppearance in requiresCustomAppearanceUpdateOnBoundsChange without regard for whether it has ever been initialized. This would get us to send an uninitialized custom appearance to the UI process, which could end up requesting a shadow.

I have a patch to initialize lots of things to their CA defaults.

Comment 1 Tim Horton 2013-12-21 21:59:46 PST

Created attachment 219862 [details]
patch

Comment 2 Tim Horton 2013-12-23 13:06:47 PST

http://trac.webkit.org/changeset/161013