Bug 126118

Summary: Figure out if node is focusable without requiring renderer
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 126073    
Attachments:
Description Flags
patch
kling: review+, buildbot: commit-queue-
fix release build
none
another none

Description Antti Koivisto 2013-12-21 06:23:16 PST 
It only needs style not renderer. With increased laziness forcing render tree construction for this is getting troublesome.
Comment 1 Antti Koivisto 2013-12-21 06:57:03 PST 
Created attachment 219850 [details]
patch
Comment 2 Andreas Kling 2013-12-21 07:07:47 PST 
Comment on attachment 219850 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=219850&action=review

This seems like a pretty good solution. r=me.

> Source/WebCore/dom/Node.cpp:566
> +    if (!document().renderView())
> +        return false;

How about checking !Document::hasLivingRenderTree() here instead?
Comment 3 Build Bot 2013-12-21 07:47:40 PST 
Comment on attachment 219850 [details]
patch

Attachment 219850 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/49668183
Comment 4 Antti Koivisto 2013-12-21 07:55:50 PST 
Created attachment 219851 [details]
fix release build
Comment 5 Antti Koivisto 2013-12-21 09:43:23 PST 
Created attachment 219853 [details]
another
Comment 6 Antti Koivisto 2013-12-21 10:48:55 PST 
https://trac.webkit.org/r160966
Comment 7 Ryosuke Niwa 2014-06-06 14:04:09 PDT 
This patch also fixed https://bugs.webkit.org/show_bug.cgi?id=133371.