Bug 126118

Summary: Figure out if node is focusable without requiring renderer
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 126073    
Attachments:
Description Flags
patch
kling: review+, buildbot: commit-queue-
fix release build
none
another none

Antti Koivisto
Reported 2013-12-21 06:23:16 PST
It only needs style not renderer. With increased laziness forcing render tree construction for this is getting troublesome.
Attachments
patch (66.35 KB, patch)
2013-12-21 06:57 PST, Antti Koivisto 		kling: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
fix release build (66.58 KB, patch)
2013-12-21 07:55 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
another (66.43 KB, patch)
2013-12-21 09:43 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2013-12-21 06:57:03 PST
Created attachment 219850 [details] patch
Andreas Kling
Comment 2 2013-12-21 07:07:47 PST
Comment on attachment 219850 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=219850&action=review This seems like a pretty good solution. r=me. > Source/WebCore/dom/Node.cpp:566 > + if (!document().renderView()) > + return false; How about checking !Document::hasLivingRenderTree() here instead?
Build Bot
Comment 3 2013-12-21 07:47:40 PST
Comment on attachment 219850 [details] patch Attachment 219850 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/49668183
Antti Koivisto
Comment 4 2013-12-21 07:55:50 PST
Created attachment 219851 [details] fix release build
Antti Koivisto
Comment 5 2013-12-21 09:43:23 PST
Created attachment 219853 [details] another
Antti Koivisto
Comment 6 2013-12-21 10:48:55 PST
https://trac.webkit.org/r160966
Ryosuke Niwa
Comment 7 2014-06-06 14:04:09 PDT
This patch also fixed https://bugs.webkit.org/show_bug.cgi?id=133371.
Note You need to log in before you can comment on or make changes to this bug.