Bug 126094

Summary: Change "threaded scrolling" terminology to "asynchronous scrolling"
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, benjamin, cmarcelo, commit-queue, esprehn+autocc, glenn, jamesr, kondapallykalyan, luiz, ossy, simon.fraser, thorton, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Simon Fraser (smfr)
Reported 2013-12-20 16:16:49 PST
Change "threaded scrolling" terminology to "asynchronous scrolling"
Attachments
Patch (71.84 KB, patch)
2013-12-20 16:24 PST, Simon Fraser (smfr) 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2013-12-20 16:24:06 PST
Created attachment 219809 [details] Patch
Simon Fraser (smfr)
Comment 2 2013-12-20 16:32:45 PST
https://trac.webkit.org/r160944
Csaba Osztrogonác
Comment 3 2013-12-21 02:36:48 PST
(In reply to comment #2) > https://trac.webkit.org/r160944 FYI: It broke the Apple Windows build. 1>WebKit.exp : error LNK2001: unresolved external symbol "public: class WTF::String __thiscall WebCore::Page::mainThreadScrollingReasonsAsText(void)" (?mainThreadScrollingReasonsAsText@Page@WebCore@@QAE?AVString@WTF@@XZ) 1>C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\bin32\WebKit.dll : fatal error LNK1120: 1 unresolved externals
Tim Horton
Comment 4 2013-12-21 02:53:07 PST
(In reply to comment #3) > (In reply to comment #2) > > https://trac.webkit.org/r160944 > > FYI: It broke the Apple Windows build. > > 1>WebKit.exp : error LNK2001: unresolved external symbol "public: class WTF::String __thiscall WebCore::Page::mainThreadScrollingReasonsAsText(void)" (?mainThreadScrollingReasonsAsText@Page@WebCore@@QAE?AVString@WTF@@XZ) > 1>C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\bin32\WebKit.dll : fatal error LNK1120: 1 unresolved externals Didn't that get fixed in http://trac.webkit.org/changeset/160948?
Csaba Osztrogonác
Comment 5 2013-12-21 14:26:46 PST
(In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > https://trac.webkit.org/r160944 > > > > FYI: It broke the Apple Windows build. > > > > 1>WebKit.exp : error LNK2001: unresolved external symbol "public: class WTF::String __thiscall WebCore::Page::mainThreadScrollingReasonsAsText(void)" (?mainThreadScrollingReasonsAsText@Page@WebCore@@QAE?AVString@WTF@@XZ) > > 1>C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\bin32\WebKit.dll : fatal error LNK1120: 1 unresolved externals > > Didn't that get fixed in http://trac.webkit.org/changeset/160948? Maybe yes ... but it seems r160944 broke the Windows build again: https://bugs.webkit.org/show_bug.cgi?id=126082#c8
Note You need to log in before you can comment on or make changes to this bug.