Bug 126080

Summary:

Pretty print LayoutUnit, LayoutPoint, and LayoutSize in gdb and lldb

Product:

WebKit

Reporter:

Bem Jones-Bey <bjonesbe>

Component:

New Bugs

Assignee:

Bem Jones-Bey <bjonesbe>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, simon.fraser, zalan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

126095

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from webkit-cq-02 for mac-mountainlion	none
Patch	none

Description Bem Jones-Bey 2013-12-20 13:37:49 PST

Pretty print LayoutUnit, LayoutPoint, and LayoutSize in gdb and lldb

Comment 1 Bem Jones-Bey 2013-12-20 13:45:07 PST

Created attachment 219788 [details]
Patch

Comment 2 WebKit Commit Bot 2013-12-20 15:06:43 PST

Comment on attachment 219788 [details]
Patch

Rejecting attachment 219788 [details] from commit-queue.

New failing tests:
dom/xhtml/level2/html/HTMLInputElement01.xhtml
Full output: http://webkit-queues.appspot.com/results/49708169

Comment 3 WebKit Commit Bot 2013-12-20 15:06:44 PST

Created attachment 219800 [details]
Archive of layout-test-results from webkit-cq-02 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

Comment 4 Bem Jones-Bey 2013-12-20 15:58:55 PST

Dear CQ, go home, you're drunk.

Comment 5 Bem Jones-Bey 2013-12-20 16:03:09 PST

(In reply to comment #4)
> Dear CQ, go home, you're drunk.

Landed manually as r160941.

Comment 6 Simon Fraser (smfr) 2013-12-20 16:34:28 PST

Does this do the right thing when subpixel is disabled?

Comment 7 zalan 2013-12-20 16:37:24 PST

(In reply to comment #6)
> Does this do the right thing when subpixel is disabled?
I don't think so. (and the hardcoded 64 value is not such a great idea either, we might change that in the future)

Comment 8 WebKit Commit Bot 2013-12-20 16:46:22 PST

Re-opened since this is blocked by bug 126095

Comment 9 zalan 2014-01-18 22:15:09 PST

Created attachment 221581 [details]
Patch

Comment 10 zalan 2014-01-18 22:19:35 PST

There were a few problems with the original patch and I tried to address them in the lldb part
1. LayoutUnit value is signed, the original patch would output incorrect px value for negative LayoutUnits
2. This patch dynamically checks the current subpixel value, so it works when the denominator gets changed or when the subpixel is disabled.

Comment 11 WebKit Commit Bot 2014-01-19 16:03:06 PST

Comment on attachment 221581 [details]
Patch

Clearing flags on attachment: 221581

Committed r162297: <http://trac.webkit.org/changeset/162297>

Comment 12 WebKit Commit Bot 2014-01-19 16:03:08 PST

All reviewed patches have been landed.  Closing bug.